public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jean Delvare" <khali@linux-fr.org>
To: hmh@hmh.eng.br
Cc: "David Brownell" <david-b@pacbell.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"gregkh@suse.de" <gregkh@suse.de>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
Subject: Re: Platform device id
Date: Tue, 11 Sep 2007 09:43:34 +0200 (CEST)	[thread overview]
Message-ID: <C5k470vB.1189496614.5481670.khali@localhost> (raw)
In-Reply-To: <20070910225205.GB1408@khazad-dum.debian.net>


Hi Henrique,

On 9/10/2007, "Henrique de Moraes Holschuh" <hmh@hmh.eng.br> wrote:
>On Sat, 08 Sep 2007, Jean Delvare wrote:
>> * Detection could be moved to user-space entirely, then we would only
>> need a way to instantiate these specific devices from user-space. This
>> exists in other areas (scsi, network) for quite some times already so
>> it shouldn't be too difficult.
>
>Don't like that one, sorry.  Detection often needs the kind of access to
>hardware that is better off contained in the kernel.

Yes, good point.

>(...)
>I will see what I can do about breaking it up in various modules.  But this
>can be unoptimal. If I took it too seriously, thinkpad-acpi would break into
>at least five different modules, if not more, and at least one or two
>modules would need to be there for the common code.  There has to be a
>middle ground somewhere, I think.

I don't know your code and I don't really have the time to look at it
in depth, but I'm a bit surprised. Presumably your driver is
implementing a number of interfaces (e.g. hwmon) and you create a class
device for each one. You can have as many class devices hanging of a
(physical) device, so I fail to see why you would need to register
several (physical) devices.

--
Jean Delvare

  reply	other threads:[~2007-09-11  8:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07 13:35 Platform device id Jean Delvare
2007-09-07 14:58 ` Dmitry Torokhov
2007-09-07 16:36   ` Jean Delvare
2007-09-07 16:41   ` David Brownell
2007-09-07 21:00     ` Henrique de Moraes Holschuh
2007-09-07 21:41       ` David Brownell
2007-09-07 22:04         ` Henrique de Moraes Holschuh
2007-09-08  0:18           ` David Brownell
2007-09-08  3:50             ` Henrique de Moraes Holschuh
2007-09-08  8:55               ` Jean Delvare
2007-09-10 22:52                 ` Henrique de Moraes Holschuh
2007-09-11  7:43                   ` Jean Delvare [this message]
2007-09-11 13:44                     ` Henrique de Moraes Holschuh
2007-09-11 14:05                       ` Jean Delvare
2007-09-07 20:56   ` Henrique de Moraes Holschuh
2007-09-08  8:40     ` Jean Delvare
2007-09-10 22:45       ` Henrique de Moraes Holschuh
2007-09-08 13:30 ` Greg KH
2007-09-09 10:54   ` [PATCH] Make platform_device.id an int Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5k470vB.1189496614.5481670.khali@localhost \
    --to=khali@linux-fr.org \
    --cc=david-b@pacbell.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@suse.de \
    --cc=hmh@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox