public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "Daniel Borkmann" <daniel@iogearbox.net>,
	"kernel test robot" <oliver.sang@intel.com>
Cc: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ast@kernel.org>, <songliubraving@fb.com>, <kernel-team@fb.com>,
	"0day robot" <lkp@intel.com>, <lkp@lists.01.org>
Subject: Re: [selftest/bpf] b83590ee1a: BUG:KASAN:slab-out-of-bounds_in_l
Date: Wed, 11 Nov 2020 14:43:31 -0800	[thread overview]
Message-ID: <C70SQCX55VG2.195MNJP5XSCJ9@maharaja> (raw)
In-Reply-To: <8f040468-f45f-d272-af37-b7e634aeefa9@iogearbox.net>

Hi Daniel,

On Mon Nov 9, 2020 at 8:54 AM PST, Daniel Borkmann wrote:
> Hi Daniel,
>
> On 11/9/20 3:54 PM, kernel test robot wrote:
> > Greeting,
> > 
> > FYI, we noticed the following commit (built with gcc-9):
> > 
> > commit: b83590ee1add052518603bae607b0524632b7793 ("[PATCH bpf v3 2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL")
> > url: https://github.com/0day-ci/linux/commits/Daniel-Xu/Fix-bpf_probe_read_user_str-overcopying/20201106-033210
> > base: https://git.kernel.org/cgit/linux/kernel/git/bpf/bpf.git master
>
> I've tossed them from the tree for now as it looks like these are adding
> regressions
> for regular strncpy_from_user() calls, please take a look.
>
> Thanks!

Sorry about the KASAN issue.

I spent a day reproing. The kasan warnings seem a bit misleading but I
think I have a fix. I'll put a v5 shortly. I'll see if any of the bots
find errors on it.

Thanks,
Daniel

      reply	other threads:[~2020-11-12  1:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 19:29 [PATCH bpf v3 0/2] Fix bpf_probe_read_user_str() overcopying Daniel Xu
2020-11-05 19:29 ` [PATCH bpf v3 1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator Daniel Xu
2020-11-12  6:37   ` [lib/strncpy_from_user.c] e65411d04b: Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode= kernel test robot
2020-11-05 19:29 ` [PATCH bpf v3 2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL Daniel Xu
2020-11-09 14:54   ` [selftest/bpf] b83590ee1a: BUG:KASAN:slab-out-of-bounds_in_l kernel test robot
2020-11-09 16:54     ` Daniel Borkmann
2020-11-11 22:43       ` Daniel Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C70SQCX55VG2.195MNJP5XSCJ9@maharaja \
    --to=dxu@dxuuu.xyz \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=oliver.sang@intel.com \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox