From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [GIT PULL] x86/asmlinkage changes for v3.12
Date: Wed, 4 Sep 2013 08:58:25 -0700 [thread overview]
Message-ID: <CA+55aFxVv==DC0JdS87V+cPr-twN+TujYg5XmgHOjJOAkZ4xwQ@mail.gmail.com> (raw)
In-Reply-To: <20130903143921.GA28290@gmail.com>
On Tue, Sep 3, 2013 at 7:39 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> Please pull the latest x86-asmlinkage-for-linus git tree from:
Grr. This one seems to introduce this annoying warning:
arch/x86/kernel/paravirt.c:66:0: warning: "DEF_NATIVE" redefined
[enabled by default]
#define DEF_NATIVE(ops, name, code) \
^
In file included from
/home/torvalds/v2.6/linux/arch/x86/include/asm/ptrace.h:65:0,
from
/home/torvalds/v2.6/linux/arch/x86/include/asm/alternative.h:8,
from
/home/torvalds/v2.6/linux/arch/x86/include/asm/bitops.h:16,
from include/linux/bitops.h:22,
from include/linux/kernel.h:10,
from include/linux/cache.h:4,
from include/linux/time.h:4,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from arch/x86/kernel/paravirt.c:22:
/home/torvalds/v2.6/linux/arch/x86/include/asm/paravirt_types.h:389:0:
note: this is the location of the previous definition
#define DEF_NATIVE(ops, name, code) \
^
when doing an allmodconfig.
Maybe it gets fixed later in the series (I am about a third through
your pull requests), but it's clearly bogus.
What the heck is wrong with that macro anyway? It is used in one
single file, and it is _defined_ twice - in two other files. Somebody
was very very confused when they wrote that code.
I'm going to let the pull stand, since it doesn't seem to actually
break anything, but this needs to be fixed.
Linus
next prev parent reply other threads:[~2013-09-04 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 14:39 [GIT PULL] x86/asmlinkage changes for v3.12 Ingo Molnar
2013-09-04 15:58 ` Linus Torvalds [this message]
2013-09-04 16:45 ` H. Peter Anvin
2013-10-04 8:28 ` Fengguang Wu
2013-10-04 14:19 ` H. Peter Anvin
2013-10-04 14:20 ` H. Peter Anvin
2013-09-04 17:18 ` [tip:x86/asmlinkage] x86, paravirt: Remove duplicate definition for DEF_NATIVE tip-bot for H. Peter Anvin
2013-09-05 0:41 ` [GIT PULL] x86/asmlinkage changes for v3.12 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxVv==DC0JdS87V+cPr-twN+TujYg5XmgHOjJOAkZ4xwQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).