From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>,
James Bottomley <jbottomley@parallels.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] block fixes for 3.1-rc
Date: Tue, 27 Sep 2011 16:52:48 -0700 [thread overview]
Message-ID: <CA+55aFxWHBEBaWfWcdOHucAiMHnTH+y1WRq6gik+=NGA1FNh=Q@mail.gmail.com> (raw)
In-Reply-To: <4E79D65A.6070406@kernel.dk>
On Wed, Sep 21, 2011 at 5:19 AM, Jens Axboe <axboe@kernel.dk> wrote:
>
> Final round of patches for 3.1.
Apparently better not.
The "block layer oopses on USB device removal" is still there, it seems.
I can even find a patch from it from Alan Stern:
https://lkml.org/lkml/2011/9/18/63
and the reason I found that was that my wife's machine just saw what
looks very much like that bug in elv_put_request().
The call chain on that particular machine was:
- __blk_put_request
blk_put_request
scsi_execute
scsi_execute_req
sd_check_events
disk_events_workfn
process_one_work
in one of the kthread helpers. It sounds like something either
generates disk events after the unplug event (despite a "safely
remove" thing), or doesn't properly wait for the disk events to have
flushed before the elevator is cleared.
The "things go oops at USB removal" reports have been with us for a
*loong* time now. Can we please get this fixed already, and have
somebody really look at it?
And if you can't figure out why it happens, at least apply Alan's
patch (or ack it).
Linus
next prev parent reply other threads:[~2011-09-27 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:19 [GIT PULL] block fixes for 3.1-rc Jens Axboe
2011-09-27 23:52 ` Linus Torvalds [this message]
2011-09-28 0:41 ` Jens Axboe
2011-09-28 14:52 ` Alan Stern
2011-09-28 14:57 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxWHBEBaWfWcdOHucAiMHnTH+y1WRq6gik+=NGA1FNh=Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).