From: Linus Torvalds <torvalds@linux-foundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: try to simplify NR_CPUS config
Date: Fri, 9 Feb 2018 14:39:26 -0800 [thread overview]
Message-ID: <CA+55aFymknkNH2mP1vX5ZLEqQwA3BgxQhZF-SUbbJMwTDL6hAA@mail.gmail.com> (raw)
In-Reply-To: <56d0376c-dc1f-334b-d392-a8c5cd85f4aa@infradead.org>
On Fri, Feb 9, 2018 at 2:01 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> This is a rather literal interpretation of Linus's suggestion.
I think it can be simplified a bit more.
If you move the definition of RANGE_END_CPUS up to before
RANGE_BEGIN_CPUS, you can then make the RANGE_BEGIN_CPUS just be
something like
default 1 if !SMP
default RANGE_END_CPUS if MAXSMP
default 2
which makes a whole lot more sense.
and if you split that RANGE_END_CPUS so that the x86-32 and x86-64
cases are separate, that makes *those* more understandable. It also
makes sense to separate since X86_BIGSMP is 32-bit only.
But yes, this looks like it's in the right direction, where we can
make each step be fairly obvious, instead of the current NR_CPUS mess
that is entirely impossible to parse for mere humans.
Linus
next prev parent reply other threads:[~2018-02-09 22:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 22:01 [PATCH] x86: try to simplify NR_CPUS config Randy Dunlap
2018-02-09 22:39 ` Linus Torvalds [this message]
2018-02-10 0:51 ` [PATCH v2] x86: " Randy Dunlap
2018-02-10 11:36 ` [PATCH] x86/Kconfig: Further simplify the " Ingo Molnar
2018-02-10 11:38 ` Ingo Molnar
2018-02-10 17:37 ` Randy Dunlap
2018-02-10 22:19 ` Linus Torvalds
2018-02-11 1:11 ` Randy Dunlap
2018-02-11 10:47 ` Ingo Molnar
2018-02-11 10:50 ` Ingo Molnar
2018-02-11 12:12 ` [tip:x86/urgent] " tip-bot for Ingo Molnar
2018-02-11 12:11 ` [tip:x86/urgent] x86/Kconfig: Simplify " tip-bot for Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFymknkNH2mP1vX5ZLEqQwA3BgxQhZF-SUbbJMwTDL6hAA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).