From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161623AbcBQOYJ (ORCPT ); Wed, 17 Feb 2016 09:24:09 -0500 Received: from mail-qg0-f44.google.com ([209.85.192.44]:34959 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030267AbcBQOYG (ORCPT ); Wed, 17 Feb 2016 09:24:06 -0500 MIME-Version: 1.0 In-Reply-To: <56C480B5.7000902@cogentembedded.com> References: <20160217133516.GA31497@amitoj-Inspiron-3542> <56C480B5.7000902@cogentembedded.com> Date: Wed, 17 Feb 2016 19:54:05 +0530 Message-ID: Subject: Re: [PATCH] lance: Return correct error code From: Amitoj Kaur Chawla To: Sergei Shtylyov Cc: netdev@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 7:46 PM, Sergei Shtylyov wrote: > Hello. > > On 2/17/2016 4:35 PM, Amitoj Kaur Chawla wrote: > >> The return value of kzalloc on failure should be -ENOMEM and > > > kzalloc() returns NULL on failure! You need to clarify your patch > description, so that it makes some sense. > Okay, thanks for the feedback. Will send v2. Amitoj