linux-next: Fixes tag needs some work in the mm-hotfixes tree

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Hi all,

In commit

  9d4dacd9cc3f ("Revert "mm/memory-failure.c: skip huge_zero_page in memory_failure()"")

Fixes tag

  Fixes: d173d5417fb ("mm/memory-failure.c: skip huge_zero_page in memory_failure()")

has these problem(s):

  - SHA1 should be at least 12 digits long

In commit

  7b5cc291112f ("mm/huge_memory: do not overkill when splitting huge_zero_page")

Fixes tag

  Fixes: d173d5417fb ("mm/memory-failure.c: skip huge_zero_page in memory_failure()")

has these problem(s):

  - SHA1 should be at least 12 digits long

These are probably not worth rebasing for but this can be fixed for the
future by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi all,

In commit

  b2f4c6e29531 ("mm/smaps: don't access young/dirty bit if pte unpresent")

Fixes tag

  Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Please do not include the date part - it adds nothing.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Peter Xu]

On Mon, Aug 08, 2022 at 07:19:41AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b2f4c6e29531 ("mm/smaps: don't access young/dirty bit if pte unpresent")
> 
> Fixes tag
> 
>   Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31)
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Please do not include the date part - it adds nothing.

The date confused the script.  I'd only rely on the 1st column (which
should definitely be the commit ID) normally for Fixes, but will remember
to use the general format in the future..

Thanks.

-- 
Peter Xu

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Hi all,

In commit

  ade5d74c84d4 ("lazy tlb: consolidate lazy tlb mm switching fix")

Fixes tag

  Fixes: a665eec0a22e1 ("powerpc/64s/radix: Fix mm_cpumask trimming race vs k>

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

I guess this is just a quoted commit message in this commit message that
has confused my script :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hi all,

In commit

  f8ff23429c62 ("kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP")

Fixes tag

  Fixes: commit 89cde455915f ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Baoquan He]

On 11/30/23 at 07:43am, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f8ff23429c62 ("kernel/Kconfig.kexec: drop select of KEXEC for CRASH_DUMP")
> 
> Fixes tag
> 
>   Fixes: commit 89cde455915f ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")
           ~~~~~~
Sorry, my fault. I didn't read the
Documentation/process/submitting-patches.rst carefully.

Maybe Andrew can help remove the 'commit' after 'Fixes:', thanks.

> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi all,

In commit

  e968e6d21d03 ("lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat")

Fixes tag

  Fixes: 5ef6dc08cfde ("lib/build_OID_registry: don't mention the full path of

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi all,

In commit

  cbd28071cdab ("mm: list_lru: fix UAF for memory cgroup")

Fixes tag

  Fixes: 0a97c01cd20b ("list_lru: allow explicit memcg and NUMA node selection)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Muchun Song]

> On Aug 5, 2024, at 05:17, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> In commit
> 
>  cbd28071cdab ("mm: list_lru: fix UAF for memory cgroup")
> 
> Fixes tag
> 
>  Fixes: 0a97c01cd20b ("list_lru: allow explicit memcg and NUMA node selection)
> 
> has these problem(s):
> 
>  - Subject has leading but no trailing quotes

Hi Stephen,

Thanks. In my v2, I've fixed this problem.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

Hi all,

In commit

  81c87e0a531b ("mm/memcontrol: respect zswap.writeback setting from parent cg too")

Fixes tag

  Fixes: 501a06fe8e4c ("zswap: memcontrol: implement zswap writeback disablin=

from the mm-hotfixes-unstable branch has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

It looks like it the Fixes line has been split by the quoted printable
mime encoding of the original email?  There is another QP artifact in
the commite message as well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi all,

In commit

  4bb3dd34459b ("selftests/mm: replace atomic_bool with pthread_barrier_t")

Fixes tag

  Fixes: 8c864371b2a1 ("selftests/mm: fix ARM related issue with fork after

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi all,

In commit

  25ee3c404f35 ("kho: mm: don't allow deferred struct page with KHO")

Fixes tag

  Fixes: 990a950fe8fd ("kexec: add config option for KHO")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4e1d010e3bda ("kexec: add config option for KHO")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Pasha Tatashin]

On Tue, Aug 12, 2025 at 6:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   25ee3c404f35 ("kho: mm: don't allow deferred struct page with KHO")
>
> Fixes tag
>
>   Fixes: 990a950fe8fd ("kexec: add config option for KHO")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 4e1d010e3bda ("kexec: add config option for KHO")

Yes, this is the correct one. Thank you!

Andrew, do you want me to send a new patch version to update the commit log?

Pasha

>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Andrew Morton]

On Tue, 12 Aug 2025 13:46:57 +0000 Pasha Tatashin <pasha.tatashin@soleen.com> wrote:

> On Tue, Aug 12, 2025 at 6:44 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   25ee3c404f35 ("kho: mm: don't allow deferred struct page with KHO")
> >
> > Fixes tag
> >
> >   Fixes: 990a950fe8fd ("kexec: add config option for KHO")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 4e1d010e3bda ("kexec: add config option for KHO")

Cool, thanks.

> Yes, this is the correct one. Thank you!
> 
> Andrew, do you want me to send a new patch version to update the commit log?

Nope, I made that change.

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

In commit

  c450c8ffc9fd ("proc: fix missing pde_set_flags() for net proc files")

Fixes tag

  Fixes: ff7ec8dc1b64 ("proc: use the same treatment to check proc_lseek as ones for proc_read_iter et.al)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-hotfixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

In commit

  d2567dc490b0 ("kexec/arm64: initialize the random field of kbuf to zero in the image loader")

Fixes tag

  Fixes: bf454ec31add ("kexec_file: allow to place kexec_buf randomly

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]