From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Ben Zong-You Xie <ben717@andestech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: cache: add specific RZ/Five compatible to ax45mp
Date: Tue, 13 May 2025 08:42:15 +0100 [thread overview]
Message-ID: <CA+V-a8sKAVEZDOxgok94YHWdE9Mgw-z3DRa8UTSf=myxe5O9pA@mail.gmail.com> (raw)
In-Reply-To: <20250512-sevenfold-yeah-d40078a9249e@spud>
On Mon, May 12, 2025 at 3:12 PM Conor Dooley <conor@kernel.org> wrote:
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> When the binding was originally written, it was assumed that all
> ax45mp-caches had the same properties etc. This has turned out to be
> incorrect, as the QiLai SoC has a different number of cache-sets.
>
> Add a specific compatible for the RZ/Five for property enforcement and
> in case there turns out to be additional differences between these
> implementations of the cache controller.
>
> Acked-by: Ben Zong-You Xie <ben717@andestech.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/cache/andestech,ax45mp-cache.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml b/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> index d2cbe49f4e15f..82668d327344e 100644
> --- a/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> +++ b/Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
> @@ -28,6 +28,7 @@ select:
> properties:
> compatible:
> items:
> + - const: renesas,r9a07g043f-ax45mp-cache
> - const: andestech,ax45mp-cache
> - const: cache
>
> @@ -70,7 +71,8 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
>
> cache-controller@13400000 {
> - compatible = "andestech,ax45mp-cache", "cache";
> + compatible = "renesas,r9a07g043f-ax45mp-cache", "andestech,ax45mp-cache",
> + "cache";
> reg = <0x13400000 0x100000>;
> interrupts = <508 IRQ_TYPE_LEVEL_HIGH>;
> cache-line-size = <64>;
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2025-05-13 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 13:48 [PATCH v2 0/2] Add specific RZ/Five cache compatible Conor Dooley
2025-05-12 13:48 ` [PATCH v2 1/2] dt-bindings: cache: add specific RZ/Five compatible to ax45mp Conor Dooley
2025-05-12 13:56 ` Geert Uytterhoeven
2025-05-13 7:42 ` Lad, Prabhakar [this message]
2025-05-12 13:48 ` [PATCH v2 2/2] riscv: dts: renesas: add specific RZ/Five cache compatible Conor Dooley
2025-05-12 13:57 ` Geert Uytterhoeven
2025-05-12 15:54 ` Conor Dooley
2025-05-13 7:42 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+V-a8sKAVEZDOxgok94YHWdE9Mgw-z3DRa8UTSf=myxe5O9pA@mail.gmail.com' \
--to=prabhakar.csengg@gmail.com \
--cc=ben717@andestech.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).