* Re: [PATCH] Add a MODULE_VERSION macro
@ 2004-02-27 16:38 Petr Vandrovec
2004-03-01 5:41 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vandrovec @ 2004-02-27 16:38 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: rusty
On 27 Feb 04 at 6:51, Linux Kernel Mailing List wrote:
> ChangeSet 1.1713, 2004/02/26 22:51:58-08:00, akpm@osdl.org
>
> [PATCH] Add a MODULE_VERSION macro
...
> diff -Nru a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> --- a/scripts/Makefile.modpost Thu Feb 26 23:11:35 2004
> +++ b/scripts/Makefile.modpost Thu Feb 26 23:11:35 2004
> @@ -10,10 +10,11 @@
...
>
> ifneq ($(filter-out $(modules),$(__modules)),)
> + $(warning Trouble: $(__modules) )
> $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> $(warning do not complain if something goes wrong.)
> endif
Hi Rusty,
what is this line supposed to do, except making it impossible
to build kernel modules in temporary directories? Now when I build
out-of-tree modules, I get 'Trouble:' followed by approximate 16000
characters listing paths to all modules I have in kernel, for no
apparent reason (I know that I removed some module I built in /tmp...
why kernel should care, that module is gone forever), so it makes
all warning & error messages completely lost 5 screens away.
Can you remove this 'Trouble:' message, or at least provide some
way to disable that message (and two warnings below it too, they
serve no useful purpose AFAICT, as they trigger whenever you'll remove
some module from directory where you built it) ? Or at least make it
useful: print only modules which are missing, not all modules.
Thanks,
Petr Vandrovec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add a MODULE_VERSION macro
2004-02-27 16:38 [PATCH] Add a MODULE_VERSION macro Petr Vandrovec
@ 2004-03-01 5:41 ` Rusty Russell
2004-03-01 12:02 ` Petr Vandrovec
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2004-03-01 5:41 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: Linux Kernel Mailing List, Sam Ravnborg
In message <CA71EA605D@vcnet.vc.cvut.cz> you write:
> > ifneq ($(filter-out $(modules),$(__modules)),)
> > + $(warning Trouble: $(__modules) )
> > $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> > $(warning do not complain if something goes wrong.)
> > endif
>
> Hi Rusty,
> what is this line supposed to do, except making it impossible
> to build kernel modules in temporary directories? Now when I build
> out-of-tree modules, I get 'Trouble:' followed by approximate 16000
> characters listing paths to all modules I have in kernel
Patch below: does it help?
Rusty
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
--- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost 2004-02-29 19:11:38.000000000 +1100
+++ tmp/scripts/Makefile.modpost 2004-03-01 16:40:33.000000000 +1100
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
ifneq ($(filter-out $(modules),$(__modules)),)
- $(warning Trouble: $(__modules) )
+ $(warning Trouble: $(filter-out $(modules),$(__modules)))
$(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
$(warning do not complain if something goes wrong.)
endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add a MODULE_VERSION macro
2004-03-01 5:41 ` Rusty Russell
@ 2004-03-01 12:02 ` Petr Vandrovec
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vandrovec @ 2004-03-01 12:02 UTC (permalink / raw)
To: Rusty Russell; +Cc: Linux Kernel Mailing List, Sam Ravnborg
On Mon, Mar 01, 2004 at 04:41:24PM +1100, Rusty Russell wrote:
> Patch below: does it help?
Yes, much better:
/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:17: Trouble: /tmp/vmware-config1/vmnet-only/vmnet.ko
/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:18: *** Uh-oh, you have stale module entries. You messed with SUBDIRS,/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:19: do not complain if something goes wrong.
Thanks,
Petr Vandrovec
>
> Rusty
> --
> Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
>
> diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
> --- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost 2004-02-29 19:11:38.000000000 +1100
> +++ tmp/scripts/Makefile.modpost 2004-03-01 16:40:33.000000000 +1100
> @@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
> modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
>
> ifneq ($(filter-out $(modules),$(__modules)),)
> - $(warning Trouble: $(__modules) )
> + $(warning Trouble: $(filter-out $(modules),$(__modules)))
> $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> $(warning do not complain if something goes wrong.)
> endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-03-01 12:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-27 16:38 [PATCH] Add a MODULE_VERSION macro Petr Vandrovec
2004-03-01 5:41 ` Rusty Russell
2004-03-01 12:02 ` Petr Vandrovec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox