linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
@ 2025-05-21 23:46 Adam Xue
  0 siblings, 0 replies; 9+ messages in thread
From: Adam Xue @ 2025-05-21 23:46 UTC (permalink / raw)
  To: manivannan.sadhasivam, slark_xiao, johan+linaro, quic_vpernami,
	tglx, fabio.porcedda, quic_msarkar, mank.wang, mhi, linux-arm-msm,
	linux-kernel
  Cc: zxue, imocanu

Add MHI controller config for EM929x. It uses the same configuration
as EM919x. Also set the MRU to 32768 to improve downlink throughput.

02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
	Subsystem: Device 18d7:0301

Signed-off-by: Adam Xue <zxue@semtech.com>
---
 drivers/bus/mhi/host/pci_generic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..9bf8e7991745 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
 	.config = &modem_sierra_em919x_config,
 	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
 	.dma_data_width = 32,
+	.mru_default = 32768,
 	.sideband_wake = false,
 };
 
@@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
 		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
+	/* EM929x (sdx65), use the same configuration as EM919x */
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
+		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
 	/* Telit FN980 hardware revision v1 */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
 		.driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info },
-- 
2.45.2


To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
@ 2025-05-28 17:59 Adam Xue
  2025-06-17  9:27 ` Manivannan Sadhasivam
  2025-07-02  1:01 ` Manivannan Sadhasivam
  0 siblings, 2 replies; 9+ messages in thread
From: Adam Xue @ 2025-05-28 17:59 UTC (permalink / raw)
  To: manivannan.sadhasivam, slark_xiao, johan+linaro, quic_vpernami,
	tglx, fabio.porcedda, quic_msarkar, mhi, linux-arm-msm,
	linux-kernel
  Cc: zxue, imocanu

Add MHI controller config for EM929x. It uses the same configuration
as EM919x. Also set the MRU to 32768 to improve downlink throughput.

02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
	Subsystem: Device 18d7:0301

Signed-off-by: Adam Xue <zxue@semtech.com>
---
 drivers/bus/mhi/host/pci_generic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..9bf8e7991745 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
 	.config = &modem_sierra_em919x_config,
 	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
 	.dma_data_width = 32,
+	.mru_default = 32768,
 	.sideband_wake = false,
 };
 
@@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
 	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
 		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
+	/* EM929x (sdx65), use the same configuration as EM919x */
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
+		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
 	/* Telit FN980 hardware revision v1 */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
 		.driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info },
-- 
2.45.2


To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-05-28 17:59 [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance Adam Xue
@ 2025-06-17  9:27 ` Manivannan Sadhasivam
  2025-06-17 14:58   ` Aleksander Morgado
  2025-06-24 16:57   ` Adam Xue
  2025-07-02  1:01 ` Manivannan Sadhasivam
  1 sibling, 2 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2025-06-17  9:27 UTC (permalink / raw)
  To: Adam Xue, Thomas Perrot, Aleksander Morgado
  Cc: manivannan.sadhasivam, slark_xiao, johan+linaro, quic_vpernami,
	tglx, fabio.porcedda, quic_msarkar, mhi, linux-arm-msm,
	linux-kernel, imocanu

On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:

+ Thomas and Aleksander (for EM919X related question)

> Add MHI controller config for EM929x. It uses the same configuration
> as EM919x. Also set the MRU to 32768 to improve downlink throughput.
> 

This also affects the EM919X modem. So I want either Thomas or Aleksander to
confirm that it doesn't cause any regression.

Rest looks good to me.

- Mani

> 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
> 	Subsystem: Device 18d7:0301
> 
> Signed-off-by: Adam Xue <zxue@semtech.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..9bf8e7991745 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
>  	.config = &modem_sierra_em919x_config,
>  	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>  	.dma_data_width = 32,
> +	.mru_default = 32768,
>  	.sideband_wake = false,
>  };
>  
> @@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
>  	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
>  		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
> +	/* EM929x (sdx65), use the same configuration as EM919x */
> +	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
> +		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
>  	/* Telit FN980 hardware revision v1 */
>  	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
>  		.driver_data = (kernel_ulong_t) &mhi_telit_fn980_hw_v1_info },
> -- 
> 2.45.2
> 
> 
> To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-06-17  9:27 ` Manivannan Sadhasivam
@ 2025-06-17 14:58   ` Aleksander Morgado
  2025-06-20  7:20     ` Thomas Perrot
  2025-06-24 16:57   ` Adam Xue
  1 sibling, 1 reply; 9+ messages in thread
From: Aleksander Morgado @ 2025-06-17 14:58 UTC (permalink / raw)
  To: Manivannan Sadhasivam
  Cc: Adam Xue, Thomas Perrot, Aleksander Morgado,
	manivannan.sadhasivam, slark_xiao, johan+linaro, quic_vpernami,
	tglx, fabio.porcedda, quic_msarkar, mhi, linux-arm-msm,
	linux-kernel, imocanu

On Tue, Jun 17, 2025 at 11:27 AM Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:
>
> + Thomas and Aleksander (for EM919X related question)
>
> > Add MHI controller config for EM929x. It uses the same configuration
> > as EM919x. Also set the MRU to 32768 to improve downlink throughput.
> >
>
> This also affects the EM919X modem. So I want either Thomas or Aleksander to
> confirm that it doesn't cause any regression.
>
> Rest looks good to me.
>
> - Mani
>
> > 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
> >       Subsystem: Device 18d7:0301
> >
> > Signed-off-by: Adam Xue <zxue@semtech.com>
> > ---
> >  drivers/bus/mhi/host/pci_generic.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> > index 03aa88795209..9bf8e7991745 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
> >       .config = &modem_sierra_em919x_config,
> >       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >       .dma_data_width = 32,
> > +     .mru_default = 32768,

I cannot test this now, I need to look for the EM9191 that I know I
have somewhere, but this default MRU update feels right. Hopefully
Thomas can verify.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-06-17 14:58   ` Aleksander Morgado
@ 2025-06-20  7:20     ` Thomas Perrot
  0 siblings, 0 replies; 9+ messages in thread
From: Thomas Perrot @ 2025-06-20  7:20 UTC (permalink / raw)
  To: Aleksander Morgado, Manivannan Sadhasivam
  Cc: thomas.perrot, Adam Xue, Aleksander Morgado,
	manivannan.sadhasivam, slark_xiao, johan+linaro, quic_vpernami,
	tglx, fabio.porcedda, quic_msarkar, mhi, linux-arm-msm,
	linux-kernel, imocanu

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

Hello,

On Tue, 2025-06-17 at 16:58 +0200, Aleksander Morgado wrote:
> On Tue, Jun 17, 2025 at 11:27 AM Manivannan Sadhasivam
> <mani@kernel.org> wrote:
> > 
> > On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:
> > 
> > + Thomas and Aleksander (for EM919X related question)
> > 
> > > Add MHI controller config for EM929x. It uses the same
> > > configuration
> > > as EM919x. Also set the MRU to 32768 to improve downlink
> > > throughput.
> > > 
> > 
> > This also affects the EM919X modem. So I want either Thomas or
> > Aleksander to
> > confirm that it doesn't cause any regression.

Sorry, I no longer have the modem to test.

Kind regards,
Thomas Perrot

> > 
> > Rest looks good to me.
> > 
> > - Mani
> > 
> > > 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc
> > > Device 0308
> > >       Subsystem: Device 18d7:0301
> > > 
> > > Signed-off-by: Adam Xue <zxue@semtech.com>
> > > ---
> > >  drivers/bus/mhi/host/pci_generic.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/bus/mhi/host/pci_generic.c
> > > b/drivers/bus/mhi/host/pci_generic.c
> > > index 03aa88795209..9bf8e7991745 100644
> > > --- a/drivers/bus/mhi/host/pci_generic.c
> > > +++ b/drivers/bus/mhi/host/pci_generic.c
> > > @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info
> > > mhi_sierra_em919x_info = {
> > >       .config = &modem_sierra_em919x_config,
> > >       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> > >       .dma_data_width = 32,
> > > +     .mru_default = 32768,
> 
> I cannot test this now, I need to look for the EM9191 that I know I
> have somewhere, but this default MRU update feels right. Hopefully
> Thomas can verify.
> 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-06-17  9:27 ` Manivannan Sadhasivam
  2025-06-17 14:58   ` Aleksander Morgado
@ 2025-06-24 16:57   ` Adam Xue
  2025-06-26 19:58     ` Adam Xue
  1 sibling, 1 reply; 9+ messages in thread
From: Adam Xue @ 2025-06-24 16:57 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Thomas Perrot, Aleksander Morgado
  Cc: manivannan.sadhasivam@linaro.org, slark_xiao@163.com,
	johan+linaro@kernel.org, quic_vpernami@quicinc.com,
	tglx@linutronix.de, fabio.porcedda@gmail.com,
	quic_msarkar@quicinc.com, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Iulian Mocanu

Hi Mani and Aleksander, 

I may collect the logs if required. Or we can ship an EM91 module for you to validate?

Thanks, 

Adam

-----Original Message-----
From: Manivannan Sadhasivam <mani@kernel.org> 
Sent: June 17, 2025 2:27 AM
To: Adam Xue <zxue@semtech.com>; Thomas Perrot <thomas.perrot@bootlin.com>; Aleksander Morgado <aleksander@aleksander.es>
Cc: manivannan.sadhasivam@linaro.org; slark_xiao@163.com; johan+linaro@kernel.org; quic_vpernami@quicinc.com; tglx@linutronix.de; fabio.porcedda@gmail.com; quic_msarkar@quicinc.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Iulian Mocanu <imocanu@semtech.com>
Subject: Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.

Caution: This email originated outside of Semtech.


On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:

+ Thomas and Aleksander (for EM919X related question)

> Add MHI controller config for EM929x. It uses the same configuration 
> as EM919x. Also set the MRU to 32768 to improve downlink throughput.
>

This also affects the EM919X modem. So I want either Thomas or Aleksander to confirm that it doesn't cause any regression.

Rest looks good to me.

- Mani

> 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
>       Subsystem: Device 18d7:0301
>
> Signed-off-by: Adam Xue <zxue@semtech.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c 
> b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..9bf8e7991745 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
>       .config = &modem_sierra_em919x_config,
>       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>       .dma_data_width = 32,
> +     .mru_default = 32768,
>       .sideband_wake = false,
>  };
>
> @@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>       /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
>               .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> },
> +     /* EM929x (sdx65), use the same configuration as EM919x */
> +     { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
> +             .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> + },
>       /* Telit FN980 hardware revision v1 */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
>               .driver_data = (kernel_ulong_t) 
> &mhi_telit_fn980_hw_v1_info },
> --
> 2.45.2
>
>
> To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

--
மணிவண்ணன் சதாசிவம்

To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-06-24 16:57   ` Adam Xue
@ 2025-06-26 19:58     ` Adam Xue
  2025-07-02  1:03       ` Manivannan Sadhasivam
  0 siblings, 1 reply; 9+ messages in thread
From: Adam Xue @ 2025-06-26 19:58 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Thomas Perrot, Aleksander Morgado
  Cc: manivannan.sadhasivam@linaro.org, slark_xiao@163.com,
	johan+linaro@kernel.org, quic_vpernami@quicinc.com,
	tglx@linutronix.de, fabio.porcedda@gmail.com,
	quic_msarkar@quicinc.com, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Iulian Mocanu

Any update on this?

Thanks, 

Adam

-----Original Message-----
From: Adam Xue <zxue@semtech.com> 
Sent: June 24, 2025 9:57 AM
To: Manivannan Sadhasivam <mani@kernel.org>; Thomas Perrot <thomas.perrot@bootlin.com>; Aleksander Morgado <aleksander@aleksander.es>
Cc: manivannan.sadhasivam@linaro.org; slark_xiao@163.com; johan+linaro@kernel.org; quic_vpernami@quicinc.com; tglx@linutronix.de; fabio.porcedda@gmail.com; quic_msarkar@quicinc.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Iulian Mocanu <imocanu@semtech.com>
Subject: RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.

Hi Mani and Aleksander, 

I may collect the logs if required. Or we can ship an EM91 module for you to validate?

Thanks, 

Adam

-----Original Message-----
From: Manivannan Sadhasivam <mani@kernel.org>
Sent: June 17, 2025 2:27 AM
To: Adam Xue <zxue@semtech.com>; Thomas Perrot <thomas.perrot@bootlin.com>; Aleksander Morgado <aleksander@aleksander.es>
Cc: manivannan.sadhasivam@linaro.org; slark_xiao@163.com; johan+linaro@kernel.org; quic_vpernami@quicinc.com; tglx@linutronix.de; fabio.porcedda@gmail.com; quic_msarkar@quicinc.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Iulian Mocanu <imocanu@semtech.com>
Subject: Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.

Caution: This email originated outside of Semtech.


On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:

+ Thomas and Aleksander (for EM919X related question)

> Add MHI controller config for EM929x. It uses the same configuration 
> as EM919x. Also set the MRU to 32768 to improve downlink throughput.
>

This also affects the EM919X modem. So I want either Thomas or Aleksander to confirm that it doesn't cause any regression.

Rest looks good to me.

- Mani

> 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
>       Subsystem: Device 18d7:0301
>
> Signed-off-by: Adam Xue <zxue@semtech.com>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 03aa88795209..9bf8e7991745 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
>       .config = &modem_sierra_em919x_config,
>       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>       .dma_data_width = 32,
> +     .mru_default = 32768,
>       .sideband_wake = false,
>  };
>
> @@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>       /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
>               .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> },
> +     /* EM929x (sdx65), use the same configuration as EM919x */
> +     { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
> +             .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> + },
>       /* Telit FN980 hardware revision v1 */
>       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
>               .driver_data = (kernel_ulong_t) 
> &mhi_telit_fn980_hw_v1_info },
> --
> 2.45.2
>
>
> To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

--
மணிவண்ணன் சதாசிவம்

To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-05-28 17:59 [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance Adam Xue
  2025-06-17  9:27 ` Manivannan Sadhasivam
@ 2025-07-02  1:01 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2025-07-02  1:01 UTC (permalink / raw)
  To: slark_xiao, johan+linaro, quic_vpernami, tglx, fabio.porcedda,
	quic_msarkar, mhi, linux-arm-msm, linux-kernel,
	Manivannan Sadhasivam, Adam Xue
  Cc: imocanu


On Wed, 28 May 2025 10:59:43 -0700, Adam Xue wrote:
> Add MHI controller config for EM929x. It uses the same configuration
> as EM919x. Also set the MRU to 32768 to improve downlink throughput.
> 
> 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
> 	Subsystem: Device 18d7:0301
> 
> 
> [...]

Applied, thanks!

[1/1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
      commit: bd78a01cdee3d2333f70e659f3c1b4ffc3fd5c42

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
  2025-06-26 19:58     ` Adam Xue
@ 2025-07-02  1:03       ` Manivannan Sadhasivam
  0 siblings, 0 replies; 9+ messages in thread
From: Manivannan Sadhasivam @ 2025-07-02  1:03 UTC (permalink / raw)
  To: Adam Xue
  Cc: Thomas Perrot, Aleksander Morgado,
	manivannan.sadhasivam@linaro.org, slark_xiao@163.com,
	johan+linaro@kernel.org, quic_vpernami@quicinc.com,
	tglx@linutronix.de, fabio.porcedda@gmail.com,
	quic_msarkar@quicinc.com, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Iulian Mocanu

On Thu, Jun 26, 2025 at 07:58:49PM +0000, Adam Xue wrote:
> Any update on this?
> 

Since there seems to be no easy way to test the patch on EM919X, I went ahead
and applied the patch.

- Mani

> Thanks, 
> 
> Adam
> 
> -----Original Message-----
> From: Adam Xue <zxue@semtech.com> 
> Sent: June 24, 2025 9:57 AM
> To: Manivannan Sadhasivam <mani@kernel.org>; Thomas Perrot <thomas.perrot@bootlin.com>; Aleksander Morgado <aleksander@aleksander.es>
> Cc: manivannan.sadhasivam@linaro.org; slark_xiao@163.com; johan+linaro@kernel.org; quic_vpernami@quicinc.com; tglx@linutronix.de; fabio.porcedda@gmail.com; quic_msarkar@quicinc.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Iulian Mocanu <imocanu@semtech.com>
> Subject: RE: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
> 
> Hi Mani and Aleksander, 
> 
> I may collect the logs if required. Or we can ship an EM91 module for you to validate?
> 
> Thanks, 
> 
> Adam
> 
> -----Original Message-----
> From: Manivannan Sadhasivam <mani@kernel.org>
> Sent: June 17, 2025 2:27 AM
> To: Adam Xue <zxue@semtech.com>; Thomas Perrot <thomas.perrot@bootlin.com>; Aleksander Morgado <aleksander@aleksander.es>
> Cc: manivannan.sadhasivam@linaro.org; slark_xiao@163.com; johan+linaro@kernel.org; quic_vpernami@quicinc.com; tglx@linutronix.de; fabio.porcedda@gmail.com; quic_msarkar@quicinc.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Iulian Mocanu <imocanu@semtech.com>
> Subject: Re: [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance.
> 
> Caution: This email originated outside of Semtech.
> 
> 
> On Wed, May 28, 2025 at 10:59:43AM -0700, Adam Xue wrote:
> 
> + Thomas and Aleksander (for EM919X related question)
> 
> > Add MHI controller config for EM929x. It uses the same configuration 
> > as EM919x. Also set the MRU to 32768 to improve downlink throughput.
> >
> 
> This also affects the EM919X modem. So I want either Thomas or Aleksander to confirm that it doesn't cause any regression.
> 
> Rest looks good to me.
> 
> - Mani
> 
> > 02:00.0 Unassigned class [ff00]: Qualcomm Technologies, Inc Device 0308
> >       Subsystem: Device 18d7:0301
> >
> > Signed-off-by: Adam Xue <zxue@semtech.com>
> > ---
> >  drivers/bus/mhi/host/pci_generic.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c
> > b/drivers/bus/mhi/host/pci_generic.c
> > index 03aa88795209..9bf8e7991745 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -695,6 +695,7 @@ static const struct mhi_pci_dev_info mhi_sierra_em919x_info = {
> >       .config = &modem_sierra_em919x_config,
> >       .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >       .dma_data_width = 32,
> > +     .mru_default = 32768,
> >       .sideband_wake = false,
> >  };
> >
> > @@ -813,6 +814,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> >       /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
> >       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
> >               .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> > },
> > +     /* EM929x (sdx65), use the same configuration as EM919x */
> > +     { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x18d7, 0x0301),
> > +             .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info 
> > + },
> >       /* Telit FN980 hardware revision v1 */
> >       { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x1C5D, 0x2000),
> >               .driver_data = (kernel_ulong_t) 
> > &mhi_telit_fn980_hw_v1_info },
> > --
> > 2.45.2
> >
> >
> > To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.
> 
> --
> மணிவண்ணன் சதாசிவம்
> 
> To view our privacy policy, including the types of personal information we collect, process and share, and the rights and options you have in this respect, see www.semtech.com/legal.

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-07-02  1:03 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-28 17:59 [PATCH v1] bus: mhi: host: pci_generic: Add support for EM929x and set MRU to 32768 for better performance Adam Xue
2025-06-17  9:27 ` Manivannan Sadhasivam
2025-06-17 14:58   ` Aleksander Morgado
2025-06-20  7:20     ` Thomas Perrot
2025-06-24 16:57   ` Adam Xue
2025-06-26 19:58     ` Adam Xue
2025-07-02  1:03       ` Manivannan Sadhasivam
2025-07-02  1:01 ` Manivannan Sadhasivam
  -- strict thread matches above, loose matches on Subject: below --
2025-05-21 23:46 Adam Xue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).