From: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
devicetree@vger.kernel.org,
Lucca Fachinetti <luccafachinetti@gmail.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml
Date: Mon, 14 Jul 2025 10:16:29 +0100 [thread overview]
Message-ID: <CAA6zWZKRA2Qn3ajN9f9o_oBTZAgrx22gP28A5CHgx=+0jFrOKg@mail.gmail.com> (raw)
In-Reply-To: <20250709-happy-gazelle-of-fascination-fe0fd4@krzk-bin>
> Driver as Linux driver or LED driver? If the first, then drop.
LED driver, might not be obvious, could change to controller,
however the datasheet refers to the device "LED driver".
> These should be people interested in this hardware, not subsystem
> maintainers.
I will let maintainers decide who should be included here perhaps ?
> Keep consistent quotes, either " or '. You made different choice for the
> same properties even...
Copied over from original poster, have not spotted that before, thanks.
> Pattern does not match entirely the reg constraints. 36 is 0x24.
Pattern allows for one or more hexadecimal values starting from 1,
so the second number should start from zero is the second error here.
Thanks !
next prev parent reply other threads:[~2025-07-14 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 14:59 [PATCH v3 0/3] Add support for is31fl3236a LED controller Pawel Zalewski
2025-07-08 14:59 ` [PATCH v3 1/3] leds/leds-is31fl32xx: add support for is31fl3236a Pawel Zalewski
2025-07-09 8:12 ` Krzysztof Kozlowski
2025-07-14 9:09 ` Pawel Zalewski
2025-07-14 9:35 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml Pawel Zalewski
2025-07-09 8:17 ` Krzysztof Kozlowski
2025-07-14 9:16 ` Pawel Zalewski [this message]
2025-07-14 9:36 ` Krzysztof Kozlowski
2025-07-09 8:18 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property Pawel Zalewski
2025-07-09 8:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA6zWZKRA2Qn3ajN9f9o_oBTZAgrx22gP28A5CHgx=+0jFrOKg@mail.gmail.com' \
--to=pzalewski@thegoodpenguin.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luccafachinetti@gmail.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).