From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbbAHD4G (ORCPT ); Wed, 7 Jan 2015 22:56:06 -0500 Received: from mail-qa0-f52.google.com ([209.85.216.52]:45526 "EHLO mail-qa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbbAHD4E (ORCPT ); Wed, 7 Jan 2015 22:56:04 -0500 MIME-Version: 1.0 From: Alexei Starovoitov Date: Wed, 7 Jan 2015 19:55:42 -0800 Message-ID: Subject: Re: scsi: non atomic allocation in mempool_alloc in atomic context To: Christoph Hellwig Cc: Jens Axboe , Sasha Levin , bvanassche@acm.org, hare@suse.de, JBottomley@parallels.com, "linux-scsi@vger.kernel.org" , LKML , Dave Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 5, 2015 at 11:42 AM, Christoph Hellwig wrote: > On Mon, Jan 05, 2015 at 12:38:04PM -0700, Jens Axboe wrote: >> That was true in earlier kernels as well, going back a few versions at >> least, preempt was disabled on calling __blk_mq_run_hw_queue(). Just >> checked, and 3.16 and later have that as the behaviour. The only change >> in 3.19 some shuffling around to avoid double preempt_disable in some >> cases, it's now using get_cpu() and friends. >> >> So we probably want do mark that as stable so we reach back to when >> scsi-mq was added, unless the originally referenced patch getting rid of >> the gfp_t mask didn't have the issue. > > Before that commit we always passed down GFP_ATOMIC, so we'll only > need the patch for 3.19. I'm seeing the same splats... what tree I can pull the fix from ? Thanks!