From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Sam James <sam@gentoo.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Quentin Monnet <qmo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/libbpf: add WERROR option
Date: Sun, 13 Jul 2025 16:03:09 -0700 [thread overview]
Message-ID: <CAADnVQLjjLoT6v3kPtVseVqPi09SU8n4buP-au2X-4PzQ6We_g@mail.gmail.com> (raw)
In-Reply-To: <871pqjofzn.fsf@gentoo.org>
On Sun, Jul 13, 2025 at 3:58 PM Sam James <sam@gentoo.org> wrote:
>
> Alexei Starovoitov <alexei.starovoitov@gmail.com> writes:
>
> > On Sat, Jul 12, 2025 at 11:24 PM Sam James <sam@gentoo.org> wrote:
> >>
> >> Daniel Borkmann <daniel@iogearbox.net> writes:
> >>
> >> > On 7/5/25 12:43 PM, Sam James wrote:
> >> >> Check the 'WERROR' variable and suppress adding '-Werror' if WERROR=0.
> >> >> This mirrors what tools/perf and other directories in tools do to
> >> >> handle
> >> >> -Werror rather than adding it unconditionally.
> >> >
> >> > Could you also add to the commit desc why you need it? Are there particular
> >> > warnings you specifically need to suppress when building under gentoo?
> >>
> >> Sure. In this case, it was https://bugs.gentoo.org/959293 where I think
> >
> > I don't recall it was reported on bpf mailing list.
> >
> >> it's fixed by
> >> https://github.com/libbpf/libbpf/commit/715808d3e2d8c54f3001ce3d7fcda0844f765969
> >
> > and looks like it was fixed by accident, so..
>
> I'll note that I've sent patches that have been merged for these
> before. It's just that they're sensitive to optimisation level and prone
> to false positives. Especially with e.g. -Og.
Yeah. Compilers do produce false positives and, like any tool,
any warning is not authoritative, but we prefer people reporting
them instead of silencing and moving on.
prev parent reply other threads:[~2025-07-13 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-05 10:43 [PATCH] tools/libbpf: add WERROR option Sam James
2025-07-07 13:18 ` Daniel Borkmann
2025-07-07 13:33 ` Quentin Monnet
2025-07-13 6:21 ` Sam James
2025-07-13 6:23 ` Sam James
2025-07-13 22:45 ` Alexei Starovoitov
2025-07-13 22:58 ` Sam James
2025-07-13 23:03 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQLjjLoT6v3kPtVseVqPi09SU8n4buP-au2X-4PzQ6We_g@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sam@gentoo.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).