[PATCH 0/2] Rocket Kconfig fixes

[PATCH 0/2] Rocket Kconfig fixes

[Heiko Stuebner]

More common indentation and depending on the actual accel framework.

Heiko Stuebner (2):
  accel/rocket: Fix indentation of Kconfig entry
  accel/rocket: Depend on DRM_ACCEL not just DRM

 drivers/accel/rocket/Kconfig | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.47.2

[PATCH 1/2] accel/rocket: Fix indentation of Kconfig entry

[Heiko Stuebner]

The general indentation for the Kconfig lines is one tab, so adapt the
lines accordingly.

The description is correctly indented (1 tab + 2 spaces) so doesn't need
changes.

Fixes: ed98261b4168 ("accel/rocket: Add a new driver for Rockchip's NPU")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/accel/rocket/Kconfig | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/accel/rocket/Kconfig b/drivers/accel/rocket/Kconfig
index 43d6cd98ec8e..af6cda273892 100644
--- a/drivers/accel/rocket/Kconfig
+++ b/drivers/accel/rocket/Kconfig
@@ -1,14 +1,14 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
 config DRM_ACCEL_ROCKET
-       tristate "Rocket (support for Rockchip NPUs)"
-       depends on DRM
-       depends on (ARCH_ROCKCHIP && ARM64) || COMPILE_TEST
-       depends on ROCKCHIP_IOMMU || COMPILE_TEST
-       depends on MMU
-       select DRM_SCHED
-       select DRM_GEM_SHMEM_HELPER
-       help
+	tristate "Rocket (support for Rockchip NPUs)"
+	depends on DRM
+	depends on (ARCH_ROCKCHIP && ARM64) || COMPILE_TEST
+	depends on ROCKCHIP_IOMMU || COMPILE_TEST
+	depends on MMU
+	select DRM_SCHED
+	select DRM_GEM_SHMEM_HELPER
+	help
 	  Choose this option if you have a Rockchip SoC that contains a
 	  compatible Neural Processing Unit (NPU), such as the RK3588. Called by
 	  Rockchip either RKNN or RKNPU, it accelerates inference of neural
-- 
2.47.2

[PATCH 2/2] accel/rocket: Depend on DRM_ACCEL not just DRM

[Heiko Stuebner]

With the current dependency on only DRM, a config of

CONFIG_DRM_ACCEL_ROCKET=y

is possible, but of course wrong, because without DRM_ACCEL the build-
system will never even enter drivers/accel/* .

So depend on DRM_ACCEL instead of just DRM.

Fixes: ed98261b4168 ("accel/rocket: Add a new driver for Rockchip's NPU")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/accel/rocket/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/rocket/Kconfig b/drivers/accel/rocket/Kconfig
index af6cda273892..16465abe0660 100644
--- a/drivers/accel/rocket/Kconfig
+++ b/drivers/accel/rocket/Kconfig
@@ -2,7 +2,7 @@
 
 config DRM_ACCEL_ROCKET
 	tristate "Rocket (support for Rockchip NPUs)"
-	depends on DRM
+	depends on DRM_ACCEL
 	depends on (ARCH_ROCKCHIP && ARM64) || COMPILE_TEST
 	depends on ROCKCHIP_IOMMU || COMPILE_TEST
 	depends on MMU
-- 
2.47.2

Re: [PATCH 0/2] Rocket Kconfig fixes

[Tomeu Vizoso]

Thanks, Heiko, I have applied them to drm-misc-next.

Regards,

Tomeu

On Thu, Aug 14, 2025 at 1:35 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> More common indentation and depending on the actual accel framework.
>
> Heiko Stuebner (2):
>   accel/rocket: Fix indentation of Kconfig entry
>   accel/rocket: Depend on DRM_ACCEL not just DRM
>
>  drivers/accel/rocket/Kconfig | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> --
> 2.47.2
>