* [PATCH] drm/tegra: fix error handling
@ 2016-07-03 6:18 Christophe JAILLET
2016-07-04 1:39 ` Alexandre Courbot
2016-11-07 12:02 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2016-07-03 6:18 UTC (permalink / raw)
To: thierry.reding, airlied, swarren, gnurou
Cc: dri-devel, linux-tegra, linux-kernel, kernel-janitors,
Christophe JAILLET
This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk'
is expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/tegra/gr3d.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c
index 0b3f2b9..13f0d1b 100644
--- a/drivers/gpu/drm/tegra/gr3d.c
+++ b/drivers/gpu/drm/tegra/gr3d.c
@@ -268,9 +268,9 @@ static int gr3d_probe(struct platform_device *pdev)
if (of_device_is_compatible(np, "nvidia,tegra30-gr3d")) {
gr3d->clk_secondary = devm_clk_get(&pdev->dev, "3d2");
- if (IS_ERR(gr3d->clk)) {
+ if (IS_ERR(gr3d->clk_secondary)) {
dev_err(&pdev->dev, "cannot get secondary clock\n");
- return PTR_ERR(gr3d->clk);
+ return PTR_ERR(gr3d->clk_secondary);
}
gr3d->rst_secondary = devm_reset_control_get(&pdev->dev,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/tegra: fix error handling
2016-07-03 6:18 [PATCH] drm/tegra: fix error handling Christophe JAILLET
@ 2016-07-04 1:39 ` Alexandre Courbot
2016-11-07 12:02 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2016-07-04 1:39 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Thierry Reding, David Airlie, Stephen Warren,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
Linux Kernel Mailing List, kernel-janitors
On Sun, Jul 3, 2016 at 3:18 PM, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk'
> is expected here.
Very likely indeed.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: fix error handling
2016-07-03 6:18 [PATCH] drm/tegra: fix error handling Christophe JAILLET
2016-07-04 1:39 ` Alexandre Courbot
@ 2016-11-07 12:02 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-11-07 12:02 UTC (permalink / raw)
To: Christophe JAILLET
Cc: airlied, swarren, gnurou, dri-devel, linux-tegra, linux-kernel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Sun, Jul 03, 2016 at 08:18:57AM +0200, Christophe JAILLET wrote:
> This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk'
> is expected here.
>
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/tegra/gr3d.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks. Sorry for not noticing this one earlier.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-07 12:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-03 6:18 [PATCH] drm/tegra: fix error handling Christophe JAILLET
2016-07-04 1:39 ` Alexandre Courbot
2016-11-07 12:02 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).