linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: hugo lee <cs.hugolee@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Sean Christopherson <seanjc@google.com>,
	pbonzini@redhat.com, tglx@linutronix.de,  mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
	 x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Yuguo Li <hugoolli@tencent.com>
Subject: Re: [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split
Date: Tue, 12 Aug 2025 18:18:16 +0800	[thread overview]
Message-ID: <CAAdeq_KUjUFz0y5rspoWLonxnh8C06NV5Dn4pGuuYPPaFJJ6XQ@mail.gmail.com> (raw)
In-Reply-To: <6a1d61925118b93badc777c2b9282d190c55a32b.camel@infradead.org>

On Tue, Aug 12, 2025 at 5:39 PM David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Mon, 2025-08-11 at 09:32 -0700, Sean Christopherson wrote:
> > On Fri, Aug 08, 2025, hugo lee wrote:
> > > On Fri, Aug 8, 2025, Sean Christopherson <seanjc@google.com> wrote:
> > > >
> > > > On Thu, Aug 07, 2025, hugo lee wrote:
> > > > > On Thu, Aug 7, 2025 Sean Christopherson wrote:
> > > > > >
> > > > > > On Wed, Aug 06, 2025, Yuguo Li wrote:
> > > > > > > When using split irqchip mode, IOAPIC is handled by QEMU while the LAPIC is
> > > > > > > emulated by KVM.  When guest disables LINT0, KVM doesn't exit to QEMU for
> > > > > > > synchronization, leaving IOAPIC unaware of this change.  This may cause vCPU
> > > > > > > to be kicked when external devices(e.g. PIT)keep sending interrupts.
> > > > > >
> > > > > > I don't entirely follow what the problem is.  Is the issue that QEMU injects an
> > > > > > IRQ that should have been blocked?  Or is QEMU forcing the vCPU to exit unnecessarily?
> > > > > >
> > > > >
> > > > > This issue is about QEMU keeps injecting should-be-blocked
> > > > > (blocked by guest and qemu just doesn't know that) IRQs.
> > > > > As a result, QEMU forces vCPU to exit unnecessarily.
> > > >
> > > > Is the problem that the guest receives spurious IRQs, or that QEMU is forcing
> > > > unnecesary exits, i.e hurting performance?
> > > >
> > >
> > > It is QEMU is forcing unnecessary exits which will hurt performance by
> > > trying to require the Big QEMU Lock in qemu_wait_io_event.
> >
> > Please elaborate on the performance impact and why the issue can't be solved in
> > QEMU.
>
> Is there a corresponding QEMU patch to use this new exit reason?

No, but the patch is done and will be submitted soon.

  reply	other threads:[~2025-08-12 10:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  8:10 [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split Yuguo Li
2025-08-06 18:20 ` Sean Christopherson
2025-08-07  8:03   ` hugo lee
2025-08-07 18:38     ` Sean Christopherson
2025-08-08  2:46       ` hugo lee
2025-08-11 16:32         ` Sean Christopherson
2025-08-12  9:39           ` David Woodhouse
2025-08-12 10:18             ` hugo lee [this message]
2025-08-12 10:08           ` hugo lee
2025-08-12 10:46             ` David Woodhouse
2025-08-12 11:50               ` hugo lee
2025-08-12 12:54                 ` David Woodhouse
2025-08-13  9:30                   ` hugo lee
2025-08-13 10:03                     ` David Woodhouse
2025-08-14  8:54                       ` hugo lee
2025-08-14  9:10                         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdeq_KUjUFz0y5rspoWLonxnh8C06NV5Dn4pGuuYPPaFJJ6XQ@mail.gmail.com \
    --to=cs.hugolee@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=hugoolli@tencent.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).