linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: hugo lee <cs.hugolee@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Sean Christopherson <seanjc@google.com>,
	pbonzini@redhat.com, tglx@linutronix.de,  mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
	 x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Yuguo Li <hugoolli@tencent.com>
Subject: Re: [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split
Date: Tue, 12 Aug 2025 19:50:50 +0800	[thread overview]
Message-ID: <CAAdeq_LmqKymD8J9tgEG5AXCXsJTQ1Z1XQan5nD-1qqUXv976w@mail.gmail.com> (raw)
In-Reply-To: <d3e44057beb8db40d90e838265df7f4a2752361a.camel@infradead.org>

On Tue, Aug 12, David Woodhouse <dwmw2@infradead.org> wrote:
>
> On Tue, 2025-08-12 at 18:08 +0800, hugo lee wrote:
> >
> > On some legacy bios images using guests, they may disable PIT
> > after booting.
>
> Do you mean they may *not* disable the PIT after booting? Linux had
> that problem for a long time, until I fixed it with
> https://git.kernel.org/torvalds/c/70e6b7d9ae3
>

True, they disabled LINT0 and left PIT unaware.

> > When irqchip=split is on, qemu will keep kicking the guest and try to
> > get the Big QEMU Lock.
>
> If it's the PIT, surely QEMU will keep stealing time pointlessly unless
> we actually disable the PIT itself? Not just the IRQ delivery? Or do
> you use this to realise that the IRQ output from the PIT isn't going
> anywhere and thus disable the event in QEMU completely?
>

I'm using this to disable the PIT event in QEMU.

I'm aiming to solve the desynchronization caused by
irqchip=split, so the VM will behave more like the
physical one.
And this synchronization could eliminate the most
performance loss here.
The meaningless PIT which causes the pointless time
cost is guests' problem, and I don't
think we should disable it without clear instructions.

  reply	other threads:[~2025-08-12 11:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  8:10 [PATCH] KVM: x86: Synchronize APIC State with QEMU when irqchip=split Yuguo Li
2025-08-06 18:20 ` Sean Christopherson
2025-08-07  8:03   ` hugo lee
2025-08-07 18:38     ` Sean Christopherson
2025-08-08  2:46       ` hugo lee
2025-08-11 16:32         ` Sean Christopherson
2025-08-12  9:39           ` David Woodhouse
2025-08-12 10:18             ` hugo lee
2025-08-12 10:08           ` hugo lee
2025-08-12 10:46             ` David Woodhouse
2025-08-12 11:50               ` hugo lee [this message]
2025-08-12 12:54                 ` David Woodhouse
2025-08-13  9:30                   ` hugo lee
2025-08-13 10:03                     ` David Woodhouse
2025-08-14  8:54                       ` hugo lee
2025-08-14  9:10                         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdeq_LmqKymD8J9tgEG5AXCXsJTQ1Z1XQan5nD-1qqUXv976w@mail.gmail.com \
    --to=cs.hugolee@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=hugoolli@tencent.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).