From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61216279DCB for ; Thu, 21 Aug 2025 22:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755815456; cv=none; b=DwOmyFQJQ5zm5m9vN4yie/XG16A4Gn3D3Re+6uBFZZ/hsny99sccAlx40DLImK8iP+F+BpepVcIczy8VrmcrW70a5tJ0jqMUKi00xhlur20QzpvpeBmj0sXw9GnybWxqH0mJ54Bf7Lj7ZGUgQbFak3AUuO94SFdIcEjU3w1JdaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755815456; c=relaxed/simple; bh=qrwTnPicyp9tNZ7V+qU5Qj6zOAnVLlyHrsqGuz2C1tQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=irOKwkJjshwZU/vIfcRPDax8hJ72+bnMas7zY4mVWWJ/Y9BrKTQjcoLq1+hv9Gy3RS8r3dKAGDMGun6DwFgeN8dR/qg8UCU5rb5XsZKdOvHtrIw0kRWg8MuR5S/eCkWjKOgUrrRZX0NsdLOikedwMqU/vypCQoicroESQcOc06U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=w9Yx9iYq; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="w9Yx9iYq" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4b29b714f8cso61461cf.1 for ; Thu, 21 Aug 2025 15:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755815453; x=1756420253; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k8MDguIpfB1tiwDQTj5aE/No4Z7doxG64RXtusp1FLM=; b=w9Yx9iYqWBuSxOxsfFF8k8P/YvFLmMjH9VYE1To1EKuzjCehrtfnhYR4pH/ZTQU+8i aS6Leayi2A8rqF2PKKNC16tQDJQWekVg0WT3myNJ44D5xb6WltMUJGK/UVlm+46sagQS HskVeDEvN2LcgZzg7XDJ2vv/DrdKAIvh1ZvZVf/W14lu+49O7IIE1sN0WouAJeuT1fKm VkrANHHl8rB9PosTYXqvfUJvQ+PtKndvcLpiHh9uxYZpSVVdv8tZQbAMQhKuxefXT3CR rReJInk76peqEellH39kHWgias42ULdQKpZBPU/75sjH5aADVUYoP41S2JT1nF4JljVX xgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755815453; x=1756420253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k8MDguIpfB1tiwDQTj5aE/No4Z7doxG64RXtusp1FLM=; b=A2gMPazFPScQb9f2mwZg93SFWw7zDyrqeP49zWixfy/rtGuYnyvN1CdFbhB21GItOO waFetXVqbcpcywgVdMTLIerg20XOLAmbqERX4Dgxp4VlZ0MgS1nUISPcOAiE3jmMTWvh F6yzmdiCbvja931WbevczdmSCuBhTRwmdgZrgSVbsBSn0dKYudz178UQmfU/9JspGmwz wLXXevI4NLnIpI6nQ+ft0v62gPKcwBfEm3aSsJzm6jfYnPhy1uwCdTUEvMwSyw3m8fj4 VKCO51kalltsc8jIID2pQkRFqwEd5TzIB59d6EOz0TyuDUc0qx6llDt7rf6nyEzMM4WU TnHg== X-Forwarded-Encrypted: i=1; AJvYcCVK/I/PY8aH3iy/O4wypWVK+GxhBnjOicoflhLQ1GVXc6JCyIoWzppGBniefl8NAsSlBK7ueDKgPyftBGU=@vger.kernel.org X-Gm-Message-State: AOJu0YxUtmqsvh3xl0fsIKE0oBDwZmHa035m0u5vdwNgK30dWQeCdk2D 2+uxtTXEFpm4RMRAP78Tp4ftlULZcELUcV8ibBh6S5RoVaKbY7g2G4wLijDHut5Jyel3LlAhjdH ikyN9vzMPaInegy6ueRD4+7qi8QHAXLzya/TNxoAF X-Gm-Gg: ASbGncujbO1HmLKGILf8NazxuU1lmdZgyccvGPprch+3hJmKKX9TVHRylrSm8hxco0y gpdNHQTq4z2115hpWfksbhi859eFHqTF+s7HdbsaKn56ZXAeRcFwPncFBT2lc0cIZBnbIaUQbux uzEsL8nn7/T/W9xENyidIBbTfDU/eysK86EI25FK807ggzIGKgmH1qLHsLIrfx1QTGXQwDuTVZ3 p6NLfj/QXtsJ86R9usZJZI6jlYBR2yjag24tLxRVChm/BVeXgzZLCHZoQ== X-Google-Smtp-Source: AGHT+IH2EHxRIc2XvOSnuoiOX6o9qCXNTtLKbVBQdBlpUCSlcPy+O7Gq5C+KP9ymQxWBlUK9RRR1skGgBYxWmAR+Khc= X-Received: by 2002:a05:622a:118c:b0:4b0:82e5:946b with SMTP id d75a77b69052e-4b2aacd5a4emr2026071cf.4.1755815452896; Thu, 21 Aug 2025 15:30:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250821042915.3712925-1-sagis@google.com> <20250821042915.3712925-6-sagis@google.com> <68a7981019500_2be23a294ba@iweiny-mobl.notmuch> In-Reply-To: <68a7981019500_2be23a294ba@iweiny-mobl.notmuch> From: Sagi Shahar Date: Thu, 21 Aug 2025 17:30:42 -0500 X-Gm-Features: Ac12FXz2B1VmOXVRyb0Ok0u4rwStMH2RK2jNtJZ5p7yUkaK07yoWYHQtSWixBO4 Message-ID: Subject: Re: [PATCH v9 05/19] KVM: selftests: Update kvm_init_vm_address_properties() for TDX To: Ira Weiny Cc: linux-kselftest@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sean Christopherson , Ackerley Tng , Ryan Afranji , Andrew Jones , Isaku Yamahata , Erdem Aktas , Rick Edgecombe , Roger Wang , Binbin Wu , Oliver Upton , "Pratik R. Sampat" , Reinette Chatre , Chao Gao , Chenyi Qiang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Adrian Hunter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 21, 2025 at 5:03=E2=80=AFPM Ira Weiny wro= te: > > Sagi Shahar wrote: > > From: Isaku Yamahata > > > > Let kvm_init_vm_address_properties() initialize vm->arch.{s_bit, tag_ma= sk} > > similar to SEV. > > > > TDX sets the shared bit based on the guest physical address width and > > currently supports 48 and 52 widths. > > > > Co-developed-by: Adrian Hunter > > Signed-off-by: Adrian Hunter > > Signed-off-by: Isaku Yamahata > > Co-developed-by: Sagi Shahar > > Signed-off-by: Sagi Shahar > > --- > > .../selftests/kvm/include/x86/tdx/tdx_util.h | 14 ++++++++++++++ > > tools/testing/selftests/kvm/lib/x86/processor.c | 12 ++++++++++-- > > 2 files changed, 24 insertions(+), 2 deletions(-) > > create mode 100644 tools/testing/selftests/kvm/include/x86/tdx/tdx_uti= l.h > > > > diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/t= ools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > > new file mode 100644 > > index 000000000000..286d5e3c24b1 > > --- /dev/null > > +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef SELFTESTS_TDX_TDX_UTIL_H > > +#define SELFTESTS_TDX_TDX_UTIL_H > > + > > +#include > > + > > +#include "kvm_util.h" > > + > > +static inline bool is_tdx_vm(struct kvm_vm *vm) > > +{ > > + return vm->type =3D=3D KVM_X86_TDX_VM; > > +} > > NIT: Might have been better to define this in 4/19 and use it there. But > looks like that logic is changed later on somewhere. So... meh. We can skip the check for KVM_X86_TDX_VM entirely in 4/19 since like you said, it's replaced with something different later on. > > Ira > > [snip]