From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D8FF3C1F for ; Fri, 18 Jul 2025 05:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752817476; cv=none; b=oWsw5YHdYiH/fJCkS570Zohfyb3ncRl29aHuzAHi2XFmviBBd71YtH/IPnPd/PuQ/oYzBv1hOn4jz7t5IxirUX801tC1H1UDBr0HXOwJ+PccT9Uz/q2+NrzH9i1By99r04qXMIxBN3ONrWCUp5BxW9eWX/ywWOlT4MsB6fL221k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752817476; c=relaxed/simple; bh=uOfllG7doj7a1aHdRHQDBCELugIwaJECvLRp7gS+K1U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hsCCH3VQdhcG+1D9+RwqCnPM7Xoh6FdCV+kcbjYtergdcsMOJ4SfwmXPQ4zPNpDRv7S81KbSsNKROpWzTG1zw447rExv1nfE9HJ1W0pC3b5oeRO287apAt4fTKL3+A7YUdHUvlIyWMDhvK2l3FpP1dMPhwnwV7ZJZBUYpITlXJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org; spf=none smtp.mailfrom=brainfault.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b=OzZnqVp6; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=brainfault.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b="OzZnqVp6" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-876231b81d5so123213839f.2 for ; Thu, 17 Jul 2025 22:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20230601.gappssmtp.com; s=20230601; t=1752817473; x=1753422273; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UbgPp2KhOfq0y4Sok/APrDX9m8Fb2lQ6Dd/Lb1wol6E=; b=OzZnqVp6gjnorGvETkBollneFqqWmu1MSW5+CNV8NhutJSgPq0pY7p8CcxzWzK/aO1 H6ZCI1pz1NwsFLnTelx4tJq0OE4aIqyZNztWsl6mW2kPoLVWCY1SmZDsXtMk8aTFb0tH YO6h8XOAFs6gNc0GzGPORadOGtzS3XotODbEhSztYn9vwBGZt6TunbK43ehP6xHFXllK /UbrWmlL2eLSpf3yXpKFor0piZn5j2gDZcEEhC1pTXEvf4f5t10yN1KpwXBIpl+6e/Rk JTW/k1mnh4qTVoLajqZrEBUqW17bxZzf4qNaX5zlLBRYIDcgUG9zNlEnmsZ41AFhcfRO Ueqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752817473; x=1753422273; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UbgPp2KhOfq0y4Sok/APrDX9m8Fb2lQ6Dd/Lb1wol6E=; b=hfHRCegGFEIrcYliJ+vg2djDrHGHaDkHnYap7FUSeT2tirjgqU4wjXWu4jve486WtJ aBmGd38Rq2b+7MxiZcj3qS9zXfYR+7SUQlEa3wTBseTMlh0L3JZBaomFHdwhosM8C/1g J84bdjZLkl739MK09X5WD92Yiz8oAD3CjMrtvo3Wy8r6kJeScHF71YxTZ5h82YvZHzO2 h+bjkIF0aREgTGojVu2CTGllwKuU/+wxpmmPTaeRE5vLwUZGgrNpUD58SSNnhxNexnsz XxM3RsiJIB+wUgm5uBXIV1ZQnvKHcBbbf+jzI2a8BjFt9TUPGrRbeC0rBUgw0HxAWMFV lktA== X-Forwarded-Encrypted: i=1; AJvYcCUz7jLIHl9Mxq/QRak+Qx3OfoDPF2j/goXSGmfpcmXHIHiCpBpoE/nMcX36l56TIQFc1PyWUkrC3Imtk1M=@vger.kernel.org X-Gm-Message-State: AOJu0YwkLU9rZRDcQPTwSod9QcaXsK4EG+qIWSgr7Qc9OUKXJ4KMe/mt AZRvV6Ghm7BC6QzG+lLJYaTpQU9bRo5bpWXu+5XYMGFvqdCjmR/VNautAIcuV7QZqwVZghucUGI UrEONr+rVDW39BQgau+UoLU75pCZ8IlGUryoikv6sYA== X-Gm-Gg: ASbGncskjDDKyzxc+702G282vSJSk3Cx1LNPubbFNwOsGrv2o6DWmefIuVmh/n1rHad wgNtePuppXjZELWpls2ktrnOJ1LV3wcm9Xy+MPywAswUxyPd7OvDNgiUH61b0QoKe5ad9gCmsee /INNJeKtjdf7wmzF4zcupMWC7zuE9nIyLITdjZYxdB0j4G9qFxyD8yvcEAsmji4TEzLBH+/GSnl 84K4EO1 X-Google-Smtp-Source: AGHT+IHDgWzcXCwj/DOJpP3ymIG8gmYK7y1xVWQRaZZ4+bN0CjPQTQhbKC7oNlsGD5d5wHcvIALI0L6dBMD+3efHuLc= X-Received: by 2002:a05:6602:140e:b0:86a:256e:12df with SMTP id ca18e2360f4ac-879c08918d9mr1244420739f.2.1752817473316; Thu, 17 Jul 2025 22:44:33 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-8-f7bba7fd9cfe@rivosinc.com> In-Reply-To: <20250522-pmu_event_info-v3-8-f7bba7fd9cfe@rivosinc.com> From: Anup Patel Date: Fri, 18 Jul 2025 11:14:21 +0530 X-Gm-Features: Ac12FXyXbFx3oQHSVcqGrTUnY6wqlJWgBpkN376n7_oc300BjXLNazpUiw8OmFU Message-ID: Subject: Re: [PATCH v3 8/9] RISC-V: KVM: Implement get event info function To: Atish Patra Cc: Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Mayuresh Chitale , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 23, 2025 at 12:33=E2=80=AFAM Atish Patra = wrote: > > The new get_event_info funciton allows the guest to query the presence > of multiple events with single SBI call. Currently, the perf driver > in linux guest invokes it for all the standard SBI PMU events. Support > the SBI function implementation in KVM as well. > > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel Regards, Anup > --- > arch/riscv/include/asm/kvm_vcpu_pmu.h | 3 ++ > arch/riscv/kvm/vcpu_pmu.c | 66 +++++++++++++++++++++++++++++= ++++++ > arch/riscv/kvm/vcpu_sbi_pmu.c | 3 ++ > 3 files changed, 72 insertions(+) > > diff --git a/arch/riscv/include/asm/kvm_vcpu_pmu.h b/arch/riscv/include/a= sm/kvm_vcpu_pmu.h > index 1d85b6617508..9a930afc8f57 100644 > --- a/arch/riscv/include/asm/kvm_vcpu_pmu.h > +++ b/arch/riscv/include/asm/kvm_vcpu_pmu.h > @@ -98,6 +98,9 @@ void kvm_riscv_vcpu_pmu_init(struct kvm_vcpu *vcpu); > int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm_vcpu *vcpu, unsigne= d long saddr_low, > unsigned long saddr_high, unsigned = long flags, > struct kvm_vcpu_sbi_return *retdata= ); > +int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu, unsigned long s= addr_low, > + unsigned long saddr_high, unsigned long= num_events, > + unsigned long flags, struct kvm_vcpu_sb= i_return *retdata); > void kvm_riscv_vcpu_pmu_deinit(struct kvm_vcpu *vcpu); > void kvm_riscv_vcpu_pmu_reset(struct kvm_vcpu *vcpu); > > diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c > index 163bd4403fd0..70a6bdfc42f5 100644 > --- a/arch/riscv/kvm/vcpu_pmu.c > +++ b/arch/riscv/kvm/vcpu_pmu.c > @@ -453,6 +453,72 @@ int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm= _vcpu *vcpu, unsigned long s > return 0; > } > > +int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu, unsigned long s= addr_low, > + unsigned long saddr_high, unsigned long= num_events, > + unsigned long flags, struct kvm_vcpu_sb= i_return *retdata) > +{ > + struct riscv_pmu_event_info *einfo; > + int shmem_size =3D num_events * sizeof(*einfo); > + gpa_t shmem; > + u32 eidx, etype; > + u64 econfig; > + int ret; > + > + if (flags !=3D 0 || (saddr_low & (SZ_16 - 1))) { > + ret =3D SBI_ERR_INVALID_PARAM; > + goto out; > + } > + > + shmem =3D saddr_low; > + if (saddr_high !=3D 0) { > + if (IS_ENABLED(CONFIG_32BIT)) { > + shmem |=3D ((gpa_t)saddr_high << 32); > + } else { > + ret =3D SBI_ERR_INVALID_ADDRESS; > + goto out; > + } > + } > + > + if (kvm_vcpu_validate_gpa_range(vcpu, shmem, shmem_size, true)) { > + ret =3D SBI_ERR_INVALID_ADDRESS; > + goto out; > + } > + > + einfo =3D kzalloc(shmem_size, GFP_KERNEL); > + if (!einfo) > + return -ENOMEM; > + > + ret =3D kvm_vcpu_read_guest(vcpu, shmem, einfo, shmem_size); > + if (ret) { > + ret =3D SBI_ERR_FAILURE; > + goto free_mem; > + } > + > + for (int i =3D 0; i < num_events; i++) { > + eidx =3D einfo[i].event_idx; > + etype =3D kvm_pmu_get_perf_event_type(eidx); > + econfig =3D kvm_pmu_get_perf_event_config(eidx, einfo[i].= event_data); > + ret =3D riscv_pmu_get_event_info(etype, econfig, NULL); > + if (ret > 0) > + einfo[i].output =3D 1; > + else > + einfo[i].output =3D 0; > + } > + > + kvm_vcpu_write_guest(vcpu, shmem, einfo, shmem_size); > + if (ret) { > + ret =3D SBI_ERR_FAILURE; > + goto free_mem; > + } > + > +free_mem: > + kfree(einfo); > +out: > + retdata->err_val =3D ret; > + > + return 0; > +} > + > int kvm_riscv_vcpu_pmu_num_ctrs(struct kvm_vcpu *vcpu, > struct kvm_vcpu_sbi_return *retdata) > { > diff --git a/arch/riscv/kvm/vcpu_sbi_pmu.c b/arch/riscv/kvm/vcpu_sbi_pmu.= c > index e4be34e03e83..a020d979d179 100644 > --- a/arch/riscv/kvm/vcpu_sbi_pmu.c > +++ b/arch/riscv/kvm/vcpu_sbi_pmu.c > @@ -73,6 +73,9 @@ static int kvm_sbi_ext_pmu_handler(struct kvm_vcpu *vcp= u, struct kvm_run *run, > case SBI_EXT_PMU_SNAPSHOT_SET_SHMEM: > ret =3D kvm_riscv_vcpu_pmu_snapshot_set_shmem(vcpu, cp->a= 0, cp->a1, cp->a2, retdata); > break; > + case SBI_EXT_PMU_EVENT_GET_INFO: > + ret =3D kvm_riscv_vcpu_pmu_event_info(vcpu, cp->a0, cp->a= 1, cp->a2, cp->a3, retdata); > + break; > default: > retdata->err_val =3D SBI_ERR_NOT_SUPPORTED; > } > > -- > 2.43.0 >