* [PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag
@ 2025-07-30 8:32 Wentao Guan
2025-08-01 8:31 ` Huacai Chen
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Guan @ 2025-07-30 8:32 UTC (permalink / raw)
To: chenhuacai
Cc: siyanteng, xry111, linux-kernel, loongarch, wangyuli, zhanjun,
Wentao Guan
Since $(LD) is directly used, hence -nostdlib is unneeded,
MIPS has removed this, we should remove it too.
bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").
In fact, other architectures also use $(LD).
fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
------
Changes in v2:
- apply commit msg edit suggestion by Yanteng Si
------
---
arch/loongarch/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
index ccd2c5e135c6..d8316f993482 100644
--- a/arch/loongarch/vdso/Makefile
+++ b/arch/loongarch/vdso/Makefile
@@ -36,7 +36,7 @@ endif
# VDSO linker flags.
ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
- $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
+ $(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
#
# Shared build commands.
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag
2025-07-30 8:32 [PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag Wentao Guan
@ 2025-08-01 8:31 ` Huacai Chen
0 siblings, 0 replies; 2+ messages in thread
From: Huacai Chen @ 2025-08-01 8:31 UTC (permalink / raw)
To: Wentao Guan; +Cc: siyanteng, xry111, linux-kernel, loongarch, wangyuli, zhanjun
Applied, thanks.
Huacai
On Wed, Jul 30, 2025 at 4:35 PM Wentao Guan <guanwentao@uniontech.com> wrote:
>
> Since $(LD) is directly used, hence -nostdlib is unneeded,
> MIPS has removed this, we should remove it too.
> bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").
>
> In fact, other architectures also use $(LD).
> fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
> 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
> 2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
> 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
>
> Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
>
> ------
> Changes in v2:
> - apply commit msg edit suggestion by Yanteng Si
> ------
> ---
> arch/loongarch/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index ccd2c5e135c6..d8316f993482 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -36,7 +36,7 @@ endif
>
> # VDSO linker flags.
> ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> - $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
> + $(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
>
> #
> # Shared build commands.
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-01 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-30 8:32 [PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag Wentao Guan
2025-08-01 8:31 ` Huacai Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).