From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbeB0WpX convert rfc822-to-8bit (ORCPT ); Tue, 27 Feb 2018 17:45:23 -0500 Received: from mga14.intel.com ([192.55.52.115]:22314 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbeB0WpV (ORCPT ); Tue, 27 Feb 2018 17:45:21 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,402,1515484800"; d="scan'208";a="31142962" From: "Rustad, Mark D" To: David Miller CC: "virtio-dev@lists.oasis-open.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "Daly, Dan" , "alex.williamson@redhat.com" , "MRustad@gmail.com" , "alexander.duyck@gmail.com" , "mst@redhat.com" Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support Thread-Topic: [RFC PATCH V3] virtio_pci: Add SR-IOV support Thread-Index: AQHTr+CjaZB1K0bLWEeVRRLgaujMr6O5X6SA Date: Tue, 27 Feb 2018 22:45:19 +0000 Message-ID: References: <20180226031911.18980.80488.stgit@mdrustad-mac04.local> <20180227.103502.2160088807348773566.davem@davemloft.net> In-Reply-To: <20180227.103502.2160088807348773566.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.233.81.61] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 27, 2018, at 7:35 AM, David Miller wrote: > > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I completely agree with your comments and wish that I had seen those things myself. > Thanks. V3 was junk, but your comments apply to V4 as well, so please ignore it. Thank you for your valuable review. -- Mark Rustad, Networking Division, Intel Corporation