From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82C612E36E9 for ; Tue, 2 Sep 2025 06:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756794299; cv=none; b=XX54uN0wWr1QUHFufEGoBlamZzFP7Tvrq5jLaa7c3C2Y61Vrqw0O5UDUP/+MaFtjQPr4wllYt3tHEAuCEppV1GeFhOSQ4e4lBaK6keSEiLj1mkKxAnr7C1SELfq7sPkTwiFeqR7K/Vps4u9MYhrhQBEIG7p2wrkU9AKLw4giPP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756794299; c=relaxed/simple; bh=/X5tvcuJAxWn3JDYkNwSrjpsesfg6FURaUkJpV2ccGw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pyX5aSlwIyYWGMxukUs7ssrAoqnRbLfDR+VYk6sImowf2Di6LH+pkBoLaj3FPU90BCRikpgMmE6Ewkw4mb3A8v4sa+AMLnPmdzNJQj5wFcJVUZTego3mAZgfx0S6YfqJ3FlcN9Amm0BToPeUU3TIYYHtiaDawR9xsSHrcmmqIFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=qK7f/sLn; arc=none smtp.client-ip=209.85.219.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="qK7f/sLn" Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-e96f401c478so4613574276.3 for ; Mon, 01 Sep 2025 23:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1756794295; x=1757399095; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T7vWWxNzseg54QZAjivUxxK0pnJ4DlOhxfw0ykDICyI=; b=qK7f/sLnPoJeVQTd9FElwAA0Tl0UFyDF1bQ3sZBHacOoeGdsYb4Luai+0J+OTwpbSo JzAFychWDM2JZkQ0Fz6jMcEqvhesOXKBgivD7UCxyF0JcaeQxWNqpccxc8fPBCnDGZNH 9Q68kGAWOAX/oc4yvr7gAi4FcQ/RgA1vot/hg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756794295; x=1757399095; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7vWWxNzseg54QZAjivUxxK0pnJ4DlOhxfw0ykDICyI=; b=xEAu+0jG+aeK8IvVmqkUSfSmn6J6iekoDlda7ZXmz51ux/skwl7/iq1lv28jt3ytBx FOyHglK2K//4QgbmacbzVYYvpxxro7vBbBwHSmwGDXdDAD6t271dOScjHBbRdllhuaCa jkqLHareuMQgJJpWbCSMdY2qA81YobJDaXUizumTgZI3RnMWLmG1W1mTW0eDv+Fi2J0X ubvDGqj2ieK1Jpbu+Zz6E93Mdq5k41EgNKyjr7I9uT/Wm9zjxDe4CK55qocoKa7Ohol6 O0sv7fnpJzUdS6geQjqeUzeM5G8tqKG1DKUT0SrPWeS4K13pvlhB2y6Q+2kxZmLmFe8Y x0nA== X-Gm-Message-State: AOJu0YzQfYfsKRAHCkjWSDxnDRqYnwtOSHctNJ8YD8FDS+P8WXJMnK+R Yw8icNue5tgNc0G3GfnEJhCj63jHBqitLUcNOlY/5cjgGR09pMedgd7+Oz263+fGcsAbuhWb+4A DEp9D/kkEDwkdDa1m+IcPhk26X2NyNFAq0yySZFQVbw== X-Gm-Gg: ASbGnct0VBMFYC+B4CnvjPKle19A0i1Zq1b3ugxKYz9EnLGfx3zQzZXDJRYCcvIRrdD MFPiaj//PxzvopZdYJwuh0sfkKJ2nztdHah3LZ/qCmn/RpflFA3i6lohBKzB04Rg8t8fAjz4GtI hyPmtjOfcHlz99rTwSpizJK6KKd06RP4oPpCFe4o8GzD8cOI137SMJoJNi54kBBAK9qNkSk3ICS ac4proa5qXp7aSL X-Google-Smtp-Source: AGHT+IEC+bhwfIsYKYd4OXHEYbsF24ESl19VnrU0Lm+wzyoJZpbOTOeMhCWWexm/yC9IvNQdZvyYLuGaB9Amv1jSkRs= X-Received: by 2002:a05:6902:e03:b0:e96:ec6a:26c7 with SMTP id 3f1490d57ef6-e98a567eea7mr11493602276.0.1756794295489; Mon, 01 Sep 2025 23:24:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> <20250722103706.3440777-3-dario.binacchi@amarulasolutions.com> <20250723050319.GA1239529-robh@kernel.org> In-Reply-To: From: Dario Binacchi Date: Tue, 2 Sep 2025 08:24:44 +0200 X-Gm-Features: Ac12FXxEccgAI8M5f9oOb9ii1ya7raF_SCejPp9-Hl3t92BIFWLzJIdX2D6ZhXo Message-ID: Subject: Re: [PATCH 2/4] dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Rob, just a gentle ping =E2=80=94 I=E2=80=99ve replied to your comments on this = patch, but I haven=E2=80=99t seen any further feedback. Thanks and regards, Dario On Wed, Jul 23, 2025 at 8:25=E2=80=AFAM Dario Binacchi wrote: > > On Wed, Jul 23, 2025 at 7:03=E2=80=AFAM Rob Herring wro= te: > > > > On Tue, Jul 22, 2025 at 12:36:16PM +0200, Dario Binacchi wrote: > > > Add support for glitch threshold configuration. A detected signal is = valid > > > only if it lasts longer than the set threshold; otherwise, it is rega= rded > > > as a glitch. > > > > > > Signed-off-by: Dario Binacchi > > > --- > > > > > > .../input/touchscreen/fsl,imx6ul-tsc.yaml | 18 ++++++++++++++++= ++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,= imx6ul-tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,i= mx6ul-tsc.yaml > > > index 678756ad0f92..2fee2940213f 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml > > > @@ -62,6 +62,23 @@ properties: > > > description: Number of data samples which are averaged for each = read. > > > enum: [ 1, 4, 8, 16, 32 ] > > > > > > + fsl,glitch-threshold: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + default: 0 > > > + enum: [ 0, 1, 2, 3 ] > > > + description: | > > > + Indicates the glitch threshold. The threshold is defined by nu= mber > > > + of clock cycles. A detect signal is only valid if it is exist = longer > > > + than threshold; otherwise, it is regarded as a glitch. > > > + 0: Normal function: 8191 clock cycles > > > + Low power mode: 9 clock cycles > > > + 1: Normal function: 4095 clock cycles > > > + Low power mode: 7 clock cycles > > > + 2: Normal function: 2047 clock cycles > > > + Low power mode: 5 clock cycles > > > + 3: Normal function: 1023 clock cycles > > > + Low power mode: 3 clock cycles > > > > Don't we have common properties for this expressed in time? Debounce > > time IIRC. > > I tried checking in > Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml, > but I didn't find anything about it. > > It exists in some specific touchscreen bindings: > - azoteq,iqs7211.yaml > - brcm,iproc-touchscreen.txt > - fsl-mx25-tcq.txt, > - ti,ads7843.yaml. > > Only fsl-mx25-tcq.txt expresses it in terms of time (ns). > > Thanks and regards, > Dario > > > > > > + > > > required: > > > - compatible > > > - reg > > > @@ -94,4 +111,5 @@ examples: > > > measure-delay-time =3D <0xfff>; > > > pre-charge-time =3D <0xffff>; > > > touchscreen-average-samples =3D <32>; > > > + fsl,glitch-threshold =3D <2>; > > > }; > > > -- > > > 2.43.0 > > > > > > > -- > > Dario Binacchi > > Senior Embedded Linux Developer > > dario.binacchi@amarulasolutions.com > > __________________________________ > > > Amarula Solutions SRL > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > T. +39 042 243 5310 > info@amarulasolutions.com > > www.amarulasolutions.com --=20 Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com