From: Stephane Eranian <eranian@google.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store
Date: Tue, 15 Jul 2014 00:49:43 +0200 [thread overview]
Message-ID: <CABPqkBTYfc6CLJNzRqxDnQPr_sdv+yE9sLq717rg0sYzHhxssg@mail.gmail.com> (raw)
In-Reply-To: <20140714223918.GE5803@tassilo.jf.intel.com>
On Tue, Jul 15, 2014 at 12:39 AM, Andi Kleen <ak@linux.intel.com> wrote:
>> I have a problem with this patch.
>>
>> It makes: perf mem -t store rec record OP_NA for the store.
>> It was recording OP_STORE before.
>>
>> I think we need to keep LD/ST info. This is useful for analysis
>> especially if we collect loads/stores simultaneously.
>>
>> Was working before for the mem-loads, mem-stores events.
>
> Ok. Would it be enough if it only worked for "mem-stores" and not
> all PEBS events?
>
Ok, do that at a minimum.
> Otherwise have to go back to an even larger PEBS constraint
> table for HSW than before.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2014-07-14 22:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 0:01 [PATCH 1/2] perf, x86: Revamp PEBS event selection Andi Kleen
2014-07-12 0:01 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-07-14 18:04 ` Stephane Eranian
2014-07-14 19:24 ` Andi Kleen
2014-07-14 22:08 ` Stephane Eranian
2014-07-14 22:39 ` Andi Kleen
2014-07-14 22:49 ` Stephane Eranian [this message]
2014-07-14 22:50 ` Stephane Eranian
2014-07-15 4:05 ` Andi Kleen
2014-07-15 8:59 ` Peter Zijlstra
2014-07-15 18:19 ` Stephane Eranian
2014-07-17 20:24 ` Stephane Eranian
2014-07-19 0:49 ` Andi Kleen
2014-07-21 21:15 ` Stephane Eranian
2014-07-14 22:10 ` [PATCH 1/2] perf, x86: Revamp PEBS event selection Stephane Eranian
-- strict thread matches above, loose matches on Subject: below --
2014-07-07 22:37 [PATCH 1/2] perf, x86: Revamp PEBS event selection v2 Andi Kleen
2014-07-07 22:37 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-03-13 21:22 [PATCH 1/2] perf, x86: Disallow setting undefined bits for PEBS events Andi Kleen
2014-03-13 21:22 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPqkBTYfc6CLJNzRqxDnQPr_sdv+yE9sLq717rg0sYzHhxssg@mail.gmail.com \
--to=eranian@google.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).