From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F212721D3F5 for ; Wed, 25 Jun 2025 07:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750836921; cv=none; b=O5R96XGTKqZn0TEWyGKn6m8L45rjlOEQ/dXlr/59+KxiL84ohQD4/swq097Gm6Jq9NrF1DiIVT7AEeGXwKnzRqA1ieFlLyTyJOHDkCYlABTvbzeFudWPkH3Wkjh3id+qUYD1QJ/PJX+Zl6Gcenn9TF3DBjHyDQeCieFYcTtI0oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750836921; c=relaxed/simple; bh=2DymnnvE184jkZ20uTvSiiI7+Y+QW2i9b6WEZQ2DOJs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uTi7TxwJtrtExwGFzPVY5Uq/Y5cPlUSX+BBeCnIv8Doa2XcFDZlVsOMlhyrrRDKpG7+UfxXDAsz0TeN7VOfi1XeaFJndzajIf5PQ/4syvZRQv1PNeH/POHHZZ0cAX4p/GuzYevVmNMWXH1LouzJAW7w5++8kUdMWxD7GEBK0M9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=srAV+ug0; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="srAV+ug0" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ade58ef47c0so129569666b.1 for ; Wed, 25 Jun 2025 00:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750836918; x=1751441718; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2DymnnvE184jkZ20uTvSiiI7+Y+QW2i9b6WEZQ2DOJs=; b=srAV+ug0q+0w5chyQ7ijAx/duJp13PTzdHzxqz03njor3fxDjKTSaMxdvbKRTCT5gZ +Bxeh6VtfhG3bTomX+QdTe81HgGz5BzUDK4udiYfRDAk+ECP7BQim++DL+2cdKRD9aA4 44nlCEEYK5P0Oodemdw27yZ6OKkgUBVIwqghmLBmMVYPmyGYZ6uKcLr1Hv+6qSuhGcCg nYjDl273AZtO8v+TZ1GmQwsTAVWSygvyVr6NnEbWVuhHAXFXlERpkKNdsp+kS4EX/9wS it+KDG+SVQlYaintKCAyowNqLIklO3lzyEQpnX/eptd3SY5uZmMOdaj11PQScdVElkxy 0xQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750836918; x=1751441718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2DymnnvE184jkZ20uTvSiiI7+Y+QW2i9b6WEZQ2DOJs=; b=SR1qJZ3lUKJTxv616VW+5HAmSidDRynRKyOZGbiZ1hytV2HXe5Zf16BSzY2mQUZk41 pW8tese3Z70Zzzv5XW7QDuKWQXuugcibnlB1HyiEiFeXTKOeSA+cKsRTbbbTASwSjVMb WZKxGUphJkC8Mv+Xk97vYBoS2RL6WE4JrU2OG1uB+9ys5ByDm991U30hyPhi5zLlNmiN j337qfeWVqGbFF41sKZP8sM95WIWSW5YssqmEjzgAKTdxGD9GFpkowsMcrZ2RAJK/sLE rq660SzlkqGPIVaW+TxmegxhCI6LqxNYVAKC+59fX34v91eAaMpjLFKz8cE89ubz6p+b 734Q== X-Forwarded-Encrypted: i=1; AJvYcCUApm2Vr8/FNWf0f/NMIdFM7fKbvo78BCfDzvil8LtHeSesxWw+1wDdbIF4Ypal2mK6WWS/nGAUZn+G2WI=@vger.kernel.org X-Gm-Message-State: AOJu0YwRpJomjbqjI7oFBzYRPsabvh6nDhcLCnOHIV9vtLq4WIFOBXAh 2TsSen/49E3khSadaQTYTp8+neNae/X1tPBTwknG3YOMJAtc5w3TJzmyksA/Cd4DWnGhF9TMOJg 8G7IK7+Pf3FMYSYxXm+lyujFsu3tMfJeQzC3+o4G48A== X-Gm-Gg: ASbGncs8J99Xy4chAVR5+cKpqDd6wSTFB7UnJUcLlxCD4nOR0uD7W6MgZJo79nOWNSI 5bQhNjTxNktdVX5t0OCuI8S/xT5yrCYT+kkUpaqvZ4L3QH0JktA2UnzHPXTkVlfqt/IH2zgkpU5 lQAEk6ay5P87fRvBNYAszFt/Opy7F7cW0Al+0lk1+9Jnsvz6Bnos5OzsT4CjPnmRQgDmJ/fy3AH Ks= X-Google-Smtp-Source: AGHT+IEyXKWCmKWZPw2kgX0twR9fcnM1z7nFPYHArFddxW4orcOtG+t3XPYgPsMNGRzQt/Onxf6tBPeKruUlJC8wqdE= X-Received: by 2002:a17:907:7215:b0:ad8:959c:c567 with SMTP id a640c23a62f3a-ae0c06af8f0mr172746266b.10.1750836918190; Wed, 25 Jun 2025 00:35:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250624-gpio-mmio-pdata-v1-0-a58c72eb556a@linaro.org> <20250624-gpio-mmio-pdata-v1-2-a58c72eb556a@linaro.org> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 25 Jun 2025 09:35:07 +0200 X-Gm-Features: AX0GCFtyVKN-DtXqrWSfe49kFtB1susJDcQJSJJYWx2PpacFz_0klmfgmBsfOl0 Message-ID: Subject: Re: [PATCH RFT 2/6] gpio: mmio: get chip label and GPIO base from device properties To: Linus Walleij Cc: Bartosz Golaszewski , Lee Jones , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Krzysztof Kozlowski , Alim Akhtar , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, patches@opensource.cirrus.com, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 24 Jun 2025 at 21:44, Linus Walleij wrot= e: > > On Tue, Jun 24, 2025 at 3:19=E2=80=AFPM Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > Ahead of removing struct bgpio_pdata support from the gpio-mmio generic > > module, let's add support for getting the relevant values from generic > > device properties. "label" is a semi-standardized property in some GPIO > > drivers so let's go with it. There's no standard "base" property, so > > let's use the name "gpio-mmio,base" to tie it to this driver > > specifically. The number of GPIOs will be retrieved using > > gpiochip_get_ngpios() so there's no need to look it up in the software > > node. > > > > Signed-off-by: Bartosz Golaszewski > > This works for me. > I wouldn't be stoked to see device trees abusing the "gpio-mmio,base" > property all of a sudden just because it now exists as a device > property though... I kind of wish we had a way to opt out of exposing > this to all the sub-property paths. But it seems tiresome, so: > > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij That's not a problem - this property is not in any DT bindings and as such is not an allowed property in DT sources. For out-of-tree DTs? We don't care about those. Bartosz