From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760963AbcINJG3 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 05:06:29 -0400
Received: from mail-oi0-f48.google.com ([209.85.218.48]:33048 "EHLO
        mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755494AbcINJGK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 05:06:10 -0400
MIME-Version: 1.0
In-Reply-To: <1473823964-27402-1-git-send-email-linux@roeck-us.net>
References: <1473823964-27402-1-git-send-email-linux@roeck-us.net>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 14 Sep 2016 11:06:08 +0200
Message-ID: <CACRpkdYSr-4wbsupAPa6Q1nd6THf9YS4TMYa5OqMzF6GNOBMxg@mail.gmail.com>
Subject: Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@roeck-us.net> wrote:

> irq_get_irq_data() can return NULL, which results in a nasty crash.
> Check its return value before passing it on to irqd_set_trigger_type().
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Should probably be tagged for stable.

Yours,
Linus Walleij