From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755922AbcEXL1R (ORCPT ); Tue, 24 May 2016 07:27:17 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34284 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469AbcEXL1M (ORCPT ); Tue, 24 May 2016 07:27:12 -0400 MIME-Version: 1.0 In-Reply-To: <3d90f889782a9c8380c3694e55a135ddd6de9bc4.1463164919.git.leonard.crestez@intel.com> References: <3d90f889782a9c8380c3694e55a135ddd6de9bc4.1463164919.git.leonard.crestez@intel.com> Date: Tue, 24 May 2016 13:27:06 +0200 Message-ID: Subject: Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request From: Linus Walleij To: Crestez Dan Leonard Cc: Jonathan Cameron , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta , Giuseppe Barba , Denis Ciocca Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard wrote: > This fixes a possible race where an interrupt arrives before complete > initialization and crashes because iio_trigger_get_drvdata returns NULL. > > Cc: Linus Walleij > Cc: Giuseppe Barba > Cc: Denis Ciocca > Signed-off-by: Crestez Dan Leonard > --- > I ran into this while breaking the driver. But since the interrupt line can be > shared the handler should always be able to accept and ignore a call. Reviewed-by: Linus Walleij However I think my patch fixing the thread issue will collide by being close in context to this so it'd be great if you could resend it on top of "iio: st_sensors: switch to a threaded interrupt"? Yours, Linus Walleij