From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C827FC64E7D for ; Tue, 24 Nov 2020 08:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86AB92075A for ; Tue, 24 Nov 2020 08:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mJUb4iGM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730782AbgKXImD (ORCPT ); Tue, 24 Nov 2020 03:42:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730774AbgKXImC (ORCPT ); Tue, 24 Nov 2020 03:42:02 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1EBC0617A6 for ; Tue, 24 Nov 2020 00:42:01 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id u19so27738129lfr.7 for ; Tue, 24 Nov 2020 00:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=mJUb4iGMJjIWX8lPMq4tIdVYYwCQ67pBbsA+TPEjhQUqZSAatFbBhuCBKyZsKh8fCc JGpV0Cc2ww5FVkjK63FldrCA9Ig/lclWUIkH+vU/D421GHQ60WDTVS7RhVSTyJmRPPbm vlKNUUw+ltheJYgTJ6WBZ/vKeTtoG5+fj2fyzvIPf8kBhK4gxu6qfLs/P1Qgksfm4fvE gCqb1lv58LleBY/hA5uwf9esy/7WwKX1IeTsIZVNuXTpHvrVix6x+q/3uc+HHz85ECOP 7c8+s1vq6e5L2fQCf1ooqPCMlZ5x42ijySwcRxEE/jL/qA+EjXMtSGYmuBEFllkrARzE mNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wvJieEgip1g2WEMiOdWtOXx++qG4HU5IWILT3U6RFgs=; b=qgPVmhVqB5dk/RrHIR9mT1+ActFmAQO8naLs0a/hP+UCwuddEaFBx3kwXWMrKMweQU VIYdkrgcp0ImPDSPD1ee0ygHK2OLHorzbo44s4Ulj9Spb8070pXo0mcJlwO2bkPrZz8t jnBiFLvejHqipULw4VvMo8pLlKpgSiv66tUzUM5m3BLWcrIMP+TYyfSPzf6X3+HzPUqL wcQUNUbfLgPT60fLkcGNvMIwM6F03nmYQlWeTGgHXkOkLcxdRZ+F80+QzTwnruJOdV/k z02f652BPOgR3TdvEJigoEnJEPq//SRKNS7v/C3dmC7WSyY5Ub2Dd/ZGiXKoyxy6+KVv riqA== X-Gm-Message-State: AOAM530fkNZXH/+oe+cFK0o1+XrMtrc75RGVvHeFccxnf+tHxNc5gsPe kVQ83yXIZLaGtmEoW51pwYJOAAqsgNs3e4ZeN/3rLQ== X-Google-Smtp-Source: ABdhPJwq8vXwP1njCi8d7YRqNvXM/K6scFYWCwRR28xF1q8lPLVDfnosAP2q9vjrVciFTOlk0Ez/FkVcAKgB/NO8E4k= X-Received: by 2002:a19:7b06:: with SMTP id w6mr1430812lfc.260.1606207319854; Tue, 24 Nov 2020 00:41:59 -0800 (PST) MIME-Version: 1.0 References: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> In-Reply-To: <85263ce8b058e80cea25c6ad6383eb256ce96cc8.1604988979.git.frank@allwinnertech.com> From: Linus Walleij Date: Tue, 24 Nov 2020 09:41:49 +0100 Message-ID: Subject: Re: [RESEND PATCH 03/19] pinctrl: sunxi: Always call chained_irq_{enter, exit} in sunxi_pinctrl_irq_handler To: Frank Lee Cc: Frank Lee , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , stable , Maxime Ripard , Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 7:24 AM Frank Lee wrote: > From: Yangtao Li > > It is found on many allwinner soc that there is a low probability that > the interrupt status cannot be read in sunxi_pinctrl_irq_handler. This > will cause the interrupt status of a gpio bank to always be active on > gic, preventing gic from responding to other spi interrupts correctly. > > So we should call the chained_irq_* each time enter sunxi_pinctrl_irq_handler(). > > Cc: stable@vger.kernel.org > Signed-off-by: Yangtao Li Patch applied. Yours, Linus Walleij