* [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro
@ 2012-07-10 6:45 Devendra Naga
2012-07-17 20:17 ` Ismael Luceno
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Naga @ 2012-07-10 6:45 UTC (permalink / raw)
To: Ben Collins, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Andrew Morton, Andrew Miller, linux-media, devel, linux-kernel
Cc: Devendra Naga
the driver duplicates the module_pci_driver code,
how?
module_pci_driver is used for those drivers whose
init and exit paths does only register and unregister
to pci API and nothing else.
so use the module_pci_driver macro instead
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/staging/media/solo6x10/core.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/staging/media/solo6x10/core.c b/drivers/staging/media/solo6x10/core.c
index d2fd842..3ee9b12 100644
--- a/drivers/staging/media/solo6x10/core.c
+++ b/drivers/staging/media/solo6x10/core.c
@@ -318,15 +318,4 @@ static struct pci_driver solo_pci_driver = {
.remove = solo_pci_remove,
};
-static int __init solo_module_init(void)
-{
- return pci_register_driver(&solo_pci_driver);
-}
-
-static void __exit solo_module_exit(void)
-{
- pci_unregister_driver(&solo_pci_driver);
-}
-
-module_init(solo_module_init);
-module_exit(solo_module_exit);
+module_pci_driver(solo_pci_driver);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro
2012-07-10 6:45 [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro Devendra Naga
@ 2012-07-17 20:17 ` Ismael Luceno
0 siblings, 0 replies; 2+ messages in thread
From: Ismael Luceno @ 2012-07-17 20:17 UTC (permalink / raw)
To: Devendra Naga
Cc: Ben Collins, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Andrew Morton, Andrew Miller, linux-media, devel, linux-kernel
On Tue, Jul 10, 2012 at 3:45 AM, Devendra Naga <devendra.aaru@gmail.com> wrote:
> the driver duplicates the module_pci_driver code,
> how?
> module_pci_driver is used for those drivers whose
> init and exit paths does only register and unregister
> to pci API and nothing else.
>
> so use the module_pci_driver macro instead
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
> drivers/staging/media/solo6x10/core.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/solo6x10/core.c b/drivers/staging/media/solo6x10/core.c
> index d2fd842..3ee9b12 100644
> --- a/drivers/staging/media/solo6x10/core.c
> +++ b/drivers/staging/media/solo6x10/core.c
> @@ -318,15 +318,4 @@ static struct pci_driver solo_pci_driver = {
> .remove = solo_pci_remove,
> };
>
> -static int __init solo_module_init(void)
> -{
> - return pci_register_driver(&solo_pci_driver);
> -}
> -
> -static void __exit solo_module_exit(void)
> -{
> - pci_unregister_driver(&solo_pci_driver);
> -}
> -
> -module_init(solo_module_init);
> -module_exit(solo_module_exit);
> +module_pci_driver(solo_pci_driver);
Acked-by: Ismael Luceno <ismael.luceno@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-17 20:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-10 6:45 [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro Devendra Naga
2012-07-17 20:17 ` Ismael Luceno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).