* [PATCH] drm/amdgpu: indent an if statement
@ 2025-06-25 15:22 Dan Carpenter
2025-06-25 15:59 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-06-25 15:22 UTC (permalink / raw)
To: Frank Min
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Mario Limonciello, Lijo Lazar, Hawking Zhang, Samuel Zhang,
Asad Kamal, Ying Li, Prike Liang, Pratap Nirujogi, amd-gfx,
dri-devel, linux-kernel, kernel-janitors
The "return true;" line wasn't indented. Also checkpatch likes when
we align the && conditions.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
index d777c049747e..a0b50a8ac9c4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
@@ -1400,8 +1400,8 @@ bool amdgpu_is_kicker_fw(struct amdgpu_device *adev)
for (i = 0; i < ARRAY_SIZE(kicker_device_list); i++) {
if (adev->pdev->device == kicker_device_list[i].device &&
- adev->pdev->revision == kicker_device_list[i].revision)
- return true;
+ adev->pdev->revision == kicker_device_list[i].revision)
+ return true;
}
return false;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: indent an if statement
2025-06-25 15:22 [PATCH] drm/amdgpu: indent an if statement Dan Carpenter
@ 2025-06-25 15:59 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2025-06-25 15:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Frank Min, Alex Deucher, Christian König, David Airlie,
Simona Vetter, Mario Limonciello, Lijo Lazar, Hawking Zhang,
Samuel Zhang, Asad Kamal, Ying Li, Prike Liang, Pratap Nirujogi,
amd-gfx, dri-devel, linux-kernel, kernel-janitors
Applied. Thanks!
Alex
On Wed, Jun 25, 2025 at 11:38 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The "return true;" line wasn't indented. Also checkpatch likes when
> we align the && conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index d777c049747e..a0b50a8ac9c4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -1400,8 +1400,8 @@ bool amdgpu_is_kicker_fw(struct amdgpu_device *adev)
>
> for (i = 0; i < ARRAY_SIZE(kicker_device_list); i++) {
> if (adev->pdev->device == kicker_device_list[i].device &&
> - adev->pdev->revision == kicker_device_list[i].revision)
> - return true;
> + adev->pdev->revision == kicker_device_list[i].revision)
> + return true;
> }
>
> return false;
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-25 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-25 15:22 [PATCH] drm/amdgpu: indent an if statement Dan Carpenter
2025-06-25 15:59 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).