From: Bjorn Helgaas <bhelgaas@google.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bin Gao <bin.gao@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"x86@kernel.org" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] x86/pci: checkpatch.pl cleanup
Date: Fri, 19 Jul 2013 15:25:04 -0600 [thread overview]
Message-ID: <CAErSpo4s2DU0AMJBE5twDcDvbUXcT=OqAKCRJUt4H5cqEqyokg@mail.gmail.com> (raw)
In-Reply-To: <20130717075813.GA14629@gmail.com>
On Wed, Jul 17, 2013 at 1:58 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Valentina Manea <valentina.manea.m@gmail.com> wrote:
>
>> This patch fixes warning and errors found by checkpatch.pl:
>>
>> * replace asm/acpi.h, asm/io.h and asm/smp.h with linux/acpi.h,
>> linux/io.h and linux/smp.h respectively
>> * remove explicit initialization to 0 of a static global variable
>> * replace printk(KERN_INFO ...) with pr_info
>> * use tabs instead of spaces for indentation
>> * arrange comments so that they adhere to Documentation/CodingStyle
>>
>> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
>
> Looks good, thanks.
>
> Bjorn, I can pick this up into tip:x86/cleanups, or would you like to put
> this into the PCI tree?
I added your ack, capitalized "PCI", "Langwell", etc. consistently,
and put it in my pci/misc branch.
Bjorn
prev parent reply other threads:[~2013-07-19 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 7:40 [PATCH v2] x86/pci: checkpatch.pl cleanup Valentina Manea
2013-07-17 7:58 ` Ingo Molnar
2013-07-19 21:25 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAErSpo4s2DU0AMJBE5twDcDvbUXcT=OqAKCRJUt4H5cqEqyokg@mail.gmail.com' \
--to=bhelgaas@google.com \
--cc=bin.gao@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=valentina.manea.m@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).