From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960Ab2L2NPe (ORCPT ); Sat, 29 Dec 2012 08:15:34 -0500 Received: from mail-vc0-f178.google.com ([209.85.220.178]:54841 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290Ab2L2NPa (ORCPT ); Sat, 29 Dec 2012 08:15:30 -0500 MIME-Version: 1.0 In-Reply-To: <1356509964.2710.12.camel@ThinkPad-T5421.cn.ibm.com> References: <1356028391-14427-1-git-send-email-fweisbec@gmail.com> <1356028391-14427-3-git-send-email-fweisbec@gmail.com> <1356509964.2710.12.camel@ThinkPad-T5421.cn.ibm.com> Date: Sat, 29 Dec 2012 14:15:29 +0100 Message-ID: Subject: Re: [PATCH 02/24] cputime: Generic on-demand virtual cputime accounting From: Frederic Weisbecker To: Li Zhong Cc: LKML , Alessio Igor Bogani , Andrew Morton , Chris Metcalf , Christoph Lameter , Geoff Levand , Gilad Ben Yossef , Hakan Akkan , Ingo Molnar , "Paul E. McKenney" , Paul Gortmaker , Peter Zijlstra , Steven Rostedt , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012/12/26 Li Zhong : > On Thu, 2012-12-20 at 19:32 +0100, Frederic Weisbecker wrote: >> diff --git a/init/Kconfig b/init/Kconfig >> index 60579d6..a64b3e8 100644 >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -340,7 +340,9 @@ config TICK_CPU_ACCOUNTING >> >> config VIRT_CPU_ACCOUNTING >> bool "Deterministic task and CPU time accounting" >> - depends on HAVE_VIRT_CPU_ACCOUNTING >> + depends on HAVE_VIRT_CPU_ACCOUNTING || HAVE_CONTEXT_TRACKING >> + select VIRT_CPU_ACCOUNTING_GEN if !HAVE_VIRT_CPU_ACCOUNTING >> + default y if PPC64 > > I saw > "init/Kconfig:346:warning: defaults for choice values not supported" > on this line. So maybe we don't need it. And we already have > "default VIRT_CPU_ACCOUNTING if PPC64" > > Thanks, Zhong Fixed for the next version, thanks!