From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C628B21A440 for ; Tue, 5 Aug 2025 04:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754369900; cv=none; b=p1kxRYqBpl65ob0qk6kuVhdufqMsANL09YMdVFw2JpUE2lQ8XYVcOCRioQK7+xOjyg16zPaT8nsFi/2JXEj2Ip0UuICvLzp3tX1YNCvSsWhzChV1JXO6ptaX63m15oqDDZkaBFUjkvg9QUqOhJ33n6vDnXVhRiuFZS8LoIAro30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754369900; c=relaxed/simple; bh=3PZdbfIvTgDh6oXznLdZrAfYCAxiqm8VHBY099ZhKvE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Ds3orrvhTA8dHIcaj0J3lmLcS5C90rWaq2kAXCicVw9GFU7tY4EVTMLDk9MuHkH9BGdKOuZ1H+Adwn7SNIMGRIpYHCH8ozxkisZjsXrtdUGRDk6wnh2IeoFTau93K52z7WZkkphC6Bhdus8V2h3t1Yun/AQAbVH/QYXHib9KhD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nTKiDSbf; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nTKiDSbf" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4b0673b0a7cso334151cf.0 for ; Mon, 04 Aug 2025 21:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754369898; x=1754974698; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NsRyVRJD8Es/gVJT/DgtUphiwIWfxJmiAoGaX7ab8fg=; b=nTKiDSbfbbm/dCekwyXKyd1ZJH+xTdgobX+8v/ODW9eBysFYb07dK2/+MiQjQkgoyj IP76TbtT/XkwHtT5x+QbIHOd21bBbvrFWfwda90EWdO/Mf4YvsXDcLfcYRrWclQfo6Ta H/Vb22fq7dRJq6AZBwOadW7qN+EmjDsQ0GrrBdUGrwETveCEB+Rux2qjWtnAOdJxyunr HMQ9UjpdwEwwHWSn2Fwhzg0vpgpA6WXnpd8BDczrWbbp1+9FBw5ynkkCA+H615f/mu50 g3vDZkBD5JohYzm932sj6J1Lu3td/OE3biAQdiZk8SlxSrMHibUN89HZkJTT148qM3JB Oi8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754369898; x=1754974698; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NsRyVRJD8Es/gVJT/DgtUphiwIWfxJmiAoGaX7ab8fg=; b=vaAf6/1JSfx/BASBas4XlTGnxApH4GgyTERkbJL7iuDPZT7WylZd9KsDi5YWEOKEcK NhXpyHRz1h9Ey1gYrklXDA1/ToVmuD3Hpx6MiZ/Fm2+yjIG/ZIj60NMXWqOJokJEkh73 isba7HpA89XJOwfB9IjA7q7fN9+MSrVABXQMPHRkCwquJN84ff6iPTR8/woHkLlgN4Gj 1/SIpbtS3UEsLDvGTFQGXRpdQ2fOU84TwVVSvF84NHZK5xU0vwGslB5sA+srwOb13I4q 3MqFQ6i1xyMiSqSY0M5MQahHH2bMyVgvVJX716VMBzfxs9aqm5tvvzmxEqECVXg6YCiM BqNg== X-Forwarded-Encrypted: i=1; AJvYcCWDHWjljWOYMYclp1ykaz+ys/2cWqXlKfx4+fd534Y0xgbYrg1nUUL4yK5MDFjsp/0+Uolv8mdEGVmNJeg=@vger.kernel.org X-Gm-Message-State: AOJu0YyWSj0X0SyvqRIjNGOC3+iLIIl1fxr6Q5PsGGxr4GSzgW0RIjMN BFZwGGRy8REO6VkMpR6PNbqRk8SXTcpwZpiXExf3c5WPqr+1Trs0yZRItzgvhDOJWlzLyaODvaL jBbYSgGIbXgWhyAo1Ynkoc/MAhCmXJwhpsyfI/lP2 X-Gm-Gg: ASbGnctU30icQA2MC5/iN4lWg+mX8Nf4GmZ5taATWSmUFp2JQ2E+cXGSyT+4g1BC76e sIM42Stp5JDGLh96glRUzdX16fhXbXcrOxofPVhL+KWrLDiwVNUWy5Okr7Yko0b+pB1C9sw8zVd Pj33ETCxZhsfERDUF/yx7KPQ3miJ0cIbMIk+7GMrcixtOWFlirS1CYucjGwgj0enElIdzs3kcKZ B3rIg== X-Google-Smtp-Source: AGHT+IHF7LACRx6CUYFvTR4STh+sJ0W20jCtRgbftCjbI3+A8IvKYyDvaKI1kDWYFQyHdN4wIO80jJ089UrccrLUHsE= X-Received: by 2002:a05:622a:4e:b0:4b0:83a3:9bac with SMTP id d75a77b69052e-4b084ffef47mr1208681cf.17.1754369897478; Mon, 04 Aug 2025 21:58:17 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250730032312.167062-1-yubowen8@huawei.com> <20250730032312.167062-3-yubowen8@huawei.com> <20250730063930.cercfcpjwnfbnskj@vireshk-i7> <9041c44e-b81a-879d-90cd-3ad0e8992c6c@hisilicon.com> <7a9030d0-e758-4d11-11aa-d694edaa79a0@hisilicon.com> In-Reply-To: From: Prashant Malani Date: Mon, 4 Aug 2025 21:58:04 -0700 X-Gm-Features: Ac12FXz8zwL_C0_-xnsUm0ufCiX6T_i7jVIErwFm3t5yDb1t9o9c5UB7mipfcrI Message-ID: Subject: Re: [PATCH 2/2] cpufreq: CPPC: Fix error handling in cppc_scale_freq_workfn() To: Jie Zhan Cc: Viresh Kumar , Bowen Yu , rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, jonathan.cameron@huawei.com, lihuisong@huawei.com, zhenglifeng1@huawei.com, Beata Michalska , Ionela Voinescu Content-Type: text/plain; charset="UTF-8" On Mon, 4 Aug 2025 at 18:12, Prashant Malani wrote: > > On Sun, 3 Aug 2025 at 23:21, Jie Zhan wrote > > On 01/08/2025 16:58, Prashant Malani wrote: > > > This begs the question: why is this work function being scheduled > > > for CPUs that are in reset or offline/powered-down at all? > > > IANAE but it sounds like it would be better to add logic to ensure this > > > work function doesn't get scheduled/executed for CPUs that > > > are truly offline/powered-down or in reset. > > Yeah good question. We may discuss that on your thread. > > OK. > Quickly looking around, it sounds having in the CPPC tick function [1] > might be a better option (one probably doesn't want to lift it beyond the > CPPC layer, since other drivers might have different behaviour). > One can add a cpu_online/cpu_enabled check there. Fixed link: [1] https://elixir.bootlin.com/linux/v6.13/source/drivers/cpufreq/cppc_cpufreq.c#L125