From: Sai Vishnu <saivishnu725@gmail.com>
To: mchehab@kernel.org
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, skhan@linuxfoundation.org
Subject: [RFC PATCH 00/04] scripts: sphinx-pre-install: add interactive option
Date: Thu, 5 Jun 2025 17:29:13 +0530 [thread overview]
Message-ID: <CAFttn56VFPjikxjhgds6LjphinStm_cN+7ZhAzsieT0gnBqBDQ@mail.gmail.com> (raw)
This RFC proposes adding an interactive mode to the sphinx-pre-install script
to guide users through installing missing dependencies for setting up sphinx.
The goal is to enhance usability by prompting users to execute distro-specific
commands, improving the experience for developers setting up the documentation
builds.
Based on feedback from the initial RFC, this series restarts fresh to outline
the planned approach. The feature will take 4 patches to completely implement,
each addressing a different section of the feature.
Planned patch series:
1. Add --interactive flag and update the script's "Usage" message
2. Implement the run_if_interactive and other helper functions
3. Add a fallback to distro detection and verify the user's choice
- Why? A user running Pop!_OS can utilize hints based on Ubuntu
but the script will not detect and return a "Unknown distro" message
- Add a package manager check for each distro-specific function to
verify the user's choice. Avoids running harmful/unsupported commands
4. Apply interactive mode to distro-specific hints - Integration
Please provide feedback/advice if necessary. Patches are ready and will be sent
in 2-3 days after gathering any possible feedback.
Please provide feedback, especially on:
1. Whether to merge patches 1 and 2
- They are both setting the starting point for the entire feature
2. How to deal with commands in recommend_sphinx_version()
- Two possible routes exist to install sphinx
- Available options: pip/pypi or distro-specific package manager
- The plan is to add a prompt that asks the user to specify a number
1 for pip, 2 for package manager, 0 to skip
Initial RFC
RFC: https://lore.kernel.org/all/20250410155414.47114-1-saivishnu725@gmail.com/
Feedback: https://lore.kernel.org/all/87ikn6bw34.fsf@trenco.lwn.net
Thank you for the time and response!
reply other threads:[~2025-06-05 11:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFttn56VFPjikxjhgds6LjphinStm_cN+7ZhAzsieT0gnBqBDQ@mail.gmail.com \
--to=saivishnu725@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).