From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7482190692 for ; Mon, 13 Jan 2025 17:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736789134; cv=none; b=bYMeY+QDFiJj3XKXuh7EUMMUPPKKbbQZdufQe/JYbk42jXS4UlEKNK4upniWJVGjyh5/QYYW2HxQ9SkuiUknEnd5YeBx2hgJBm7glPP5Zt+bVaXRhSZzUrqIHY4xY/QJIr1Y1/cN8A2D8fZgGm2LUPO4djRnlXftAl7iikHPiYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736789134; c=relaxed/simple; bh=vL73DTZEQA491l3CcRUG+V/Qi6AcCjYqflWH5ZCTIvI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=YQPL59KGyvkR6ucXP0IUiXW7WPHxad2vZ8OmejuqGuccq8OlE8q8enhakUvnKJYqAojk0DOJZGGFdhJWrK45Ni3qfENmvmUnBsSwqxXbtrbUvBE6FPcSj7JmtM8wVEE3LnrmWG48mHzjDt1NKLeL7GDacPnP5MqCTj/8yUe88ZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jl8UwtFL; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jl8UwtFL" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d442f9d285so9707a12.1 for ; Mon, 13 Jan 2025 09:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736789131; x=1737393931; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1qfv4tSt68v2OjlivyRQ+MocYt9gBxYVRMLbaNwiKiU=; b=jl8UwtFLUmNX0Ut+v4GBANF0JWA8GzlU1YiVUVTsdvdc7egFtRU0IDIVwLLmhI4TKM BhWkQjGBR+CdxYmFt6JKrcnY2ngjM6LnC3qXSMGM6AmquxKOWpp9Ndi9ZWDuimt49tuE tmUcN2EwhtfTas9LP3BD8yCzgyASQhtIrxVqqThTIpJcgkfBf6OKixTPYOikeybY3OPm q2EoWEt1Yyl9Tb+uVeGRxgFIjj9Jx+DNVktk5C6OhBsnwy6mAV8N6BiAIQ3SZ4wfGpPt dhdRumbL3VGvyLLnWQBMyx812YvVLlSoYh2saAM4OJZ3cXpU3oyJ9wUd2Bzb9Q8KQjSO oytg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736789131; x=1737393931; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qfv4tSt68v2OjlivyRQ+MocYt9gBxYVRMLbaNwiKiU=; b=c7/rBMQJM/OG+70AiLipaYLjhDBn9AtBYPQMXbChas6SKygYQRo/Rw9pG3n9lCyspg YlX/hmZjOEmhjQM+3dKshSgdPHE4xiYLcRZVCETDN9l1x61ASsf/I+JWgUd9ULOyl3ho 40MxhGw5O9YcBlqBSIFTkYzugOrsGzGHVwCWYdigMNvrwRm3STkTD6HC4DFvMC9KDBfE wLhYbFHMsmbJd1VH+bTxElHCdR78YM2X81Ys9Yl42HFIxM6raxn4q/C8vr84LDfkYMK+ Ar/IaJfXfxwv8GqyeOt4oBiNbt7oRZd9hupy/PQ/X8KlR4/01ta3nn6u3KNcWGcaBhAl BmIA== X-Forwarded-Encrypted: i=1; AJvYcCWTZmptCz3W3X9xBlo51yAPXysOpP206typWd3KuWDW9m3iLt3ihQZcDGfeW7U7bIcIO3MYVlJtFv/BeLA=@vger.kernel.org X-Gm-Message-State: AOJu0YxqOkku2ThvnM/bV23J90zNzL5U1d/ykUQvJTwAVLuMqgWiaXho 5Hrg/TOQ8Lp2UovzNRBM8CoNieIHE7aj2wwns4W6BO54FsWvAn6vjaPNhDUhT3DdA6jVBJNvyeE /Bm9Tlvztcb7l/IvjgSHNkUj/oeHBAvFMWqi5 X-Gm-Gg: ASbGncsNynvAeR27GKgCPv3IqV9/2TSGTL0M2LcYPUD0TkcDsSUTY4KJ+dzuVMyvPrk 9iPko2P7lO8WQTMIoZety9mKtVty38TLunJhKXr1lx2oK7bDCRGcKBqch0dcuJGGR7A== X-Google-Smtp-Source: AGHT+IF5IklE9/KPlmAY7nB0Yh3AewBcg5TtP9qRlH4gktezO+oAIzkIcfy8QYZmMWbvksdSwXwHplfsYMN3U386Qws= X-Received: by 2002:a05:6402:1d84:b0:5d0:84a6:f1a1 with SMTP id 4fb4d7f45d1cf-5d99fbd7c37mr275511a12.6.1736789130729; Mon, 13 Jan 2025 09:25:30 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-6-riel@surriel.com> In-Reply-To: <20250112155453.1104139-6-riel@surriel.com> From: Jann Horn Date: Mon, 13 Jan 2025 18:24:54 +0100 X-Gm-Features: AbW1kvZ0J3l5YeisM7wSBI7HTA8kNyQ-kF6DQyQR0uEK5SEuEbKbsLDQeRRF_JA Message-ID: Subject: Re: [PATCH v4 05/12] x86/mm: add INVLPGB support code To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 12, 2025 at 4:55=E2=80=AFPM Rik van Riel wro= te: > +/* Wait for INVLPGB originated by this CPU to complete. */ > +static inline void tlbsync(void) > +{ > + asm volatile("tlbsync"); > +} If possible, it might be a good idea to add a cant_migrate() assertion in here, though I'm not sure if that works in terms of include hierarchy.