From: Chanwoo Choi <cwchoi00@gmail.com>
To: Peter Chen <peter.chen@nxp.com>
Cc: linux-renesas-soc@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle
Date: Sat, 2 Jul 2016 13:46:20 +0900 [thread overview]
Message-ID: <CAGTfZH0vSSNSJQHaNFjzd_ciPAcRG8bST-W5bacA2mi4T7sQTg@mail.gmail.com> (raw)
In-Reply-To: <1467366121-14120-2-git-send-email-peter.chen@nxp.com>
Hi Peter,
Applied it.
Regards,
Chanwoo Choi
2016-07-01 18:41 GMT+09:00 Peter Chen <peter.chen@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/extcon/extcon.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 21a123c..86ea14d 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1107,10 +1107,12 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
> list_for_each_entry(edev, &extcon_dev_list, entry) {
> if (edev->dev.parent && edev->dev.parent->of_node == node) {
> mutex_unlock(&extcon_dev_list_lock);
> + of_node_put(node);
> return edev;
> }
> }
> mutex_unlock(&extcon_dev_list_lock);
> + of_node_put(node);
>
> return ERR_PTR(-EPROBE_DEFER);
> }
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-07-02 4:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:41 [PATCH 0/7] add missing of_node_put after calling of_parse_phandle (1st) Peter Chen
2016-07-01 9:41 ` [PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-02 4:46 ` Chanwoo Choi [this message]
2016-07-01 9:41 ` [PATCH 2/7] arm: mach-shmobile: pm-rmobile: " Peter Chen
2016-07-01 12:31 ` Geert Uytterhoeven
2016-07-04 2:10 ` Peter Chen
2016-07-01 9:41 ` [PATCH 3/7] arm: mach-u300: regulator: " Peter Chen
2016-07-05 21:24 ` Linus Walleij
2016-07-01 9:41 ` [PATCH 4/7] bus: arm-cci: " Peter Chen
2016-07-01 10:29 ` Suzuki K Poulose
2016-07-01 10:33 ` Will Deacon
2016-07-04 2:48 ` Peter Chen
2016-07-04 9:19 ` Will Deacon
2016-07-01 9:41 ` [PATCH 5/7] bus: vexpress-config: " Peter Chen
2016-07-11 9:02 ` Liviu Dudau
2016-07-01 9:42 ` [PATCH 6/7] devfreq: " Peter Chen
2016-07-01 9:42 ` [PATCH 7/7] devfreq: exynos-bus: " Peter Chen
2016-07-02 4:53 ` Chanwoo Choi
[not found] ` <CGME20160701094923epcas1p164cc8773ec44a00dfc506a6192df3409@epcas1p1.samsung.com>
2016-07-06 2:38 ` [PATCH 6/7] devfreq: " MyungJoo Ham
[not found] ` <CGME20160701094927epcas1p43f956ee3465f96e2f9c99b44c0f5b49d@epcas1p4.samsung.com>
2016-07-06 2:47 ` [PATCH 7/7] devfreq: exynos-bus: " MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGTfZH0vSSNSJQHaNFjzd_ciPAcRG8bST-W5bacA2mi4T7sQTg@mail.gmail.com \
--to=cwchoi00@gmail.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).