* [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors
@ 2025-05-15 23:48 Randy Dunlap
2025-07-14 11:17 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2025-05-15 23:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Svyatoslav Ryhel, Chanwoo Choi, MyungJoo Ham
Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
subsequent build errors:
WARNING: unmet direct dependencies detected for REGMAP_I2C
Depends on [m]: I2C [=m]
Selected by [y]:
- EXTCON_MAX14526 [=y] && EXTCON [=y]
ld: vmlinux.o: in function `max14526_driver_init':
extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
ld: vmlinux.o: in function `max14526_driver_exit':
extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'
Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20250515.orig/drivers/extcon/Kconfig
+++ linux-next-20250515/drivers/extcon/Kconfig
@@ -136,6 +136,7 @@ config EXTCON_MAX8997
config EXTCON_MAX14526
tristate "Maxim MAX14526 EXTCON Support"
+ depends on I2C
select IRQ_DOMAIN
select REGMAP_I2C
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors
2025-05-15 23:48 [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors Randy Dunlap
@ 2025-07-14 11:17 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2025-07-14 11:17 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Svyatoslav Ryhel, Chanwoo Choi, MyungJoo Ham
Hi,
Applied it. Thanks.
On Fri, May 16, 2025 at 9:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
> subsequent build errors:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
> Depends on [m]: I2C [=m]
> Selected by [y]:
> - EXTCON_MAX14526 [=y] && EXTCON [=y]
>
> ld: vmlinux.o: in function `max14526_driver_init':
> extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
> ld: vmlinux.o: in function `max14526_driver_exit':
> extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Svyatoslav Ryhel <clamor95@gmail.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20250515.orig/drivers/extcon/Kconfig
> +++ linux-next-20250515/drivers/extcon/Kconfig
> @@ -136,6 +136,7 @@ config EXTCON_MAX8997
>
> config EXTCON_MAX14526
> tristate "Maxim MAX14526 EXTCON Support"
> + depends on I2C
> select IRQ_DOMAIN
> select REGMAP_I2C
> help
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-14 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-15 23:48 [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors Randy Dunlap
2025-07-14 11:17 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).