From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: LKML <linux-kernel@vger.kernel.org>, Ivo van Doorn <IvDoorn@gmail.com>
Subject: Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree
Date: Wed, 18 Jun 2014 09:59:37 +0200 [thread overview]
Message-ID: <CAGXE3d9aNXtOF3QTh99MU8FRPd0sdMP-d1Do6qYDJbTpdwcGUg@mail.gmail.com> (raw)
In-Reply-To: <1403033788-8315-1-git-send-email-fabf@skynet.be>
Hi,
On Tue, Jun 17, 2014 at 9:36 PM, Fabian Frederick <fabf@skynet.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
Thanks Fabian.
This should go through the wireless tree I guess, mind to send to
linux-wireless@vger.kernel.org?
Helmut
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
> Cc: Helmut Schaa <helmut.schaa@googlemail.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 2bde672..c2c2300 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> /*
> * Free the driver data.
> */
> - if (rt2x00dev->drv_data)
> - kfree(rt2x00dev->drv_data);
> + kfree(rt2x00dev->drv_data);
> }
> EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
>
> --
> 1.8.4.5
>
prev parent reply other threads:[~2014-06-18 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:36 [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree Fabian Frederick
2014-06-18 7:59 ` Helmut Schaa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXE3d9aNXtOF3QTh99MU8FRPd0sdMP-d1Do6qYDJbTpdwcGUg@mail.gmail.com \
--to=helmut.schaa@googlemail.com \
--cc=IvDoorn@gmail.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).