From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3062E4C92 for ; Tue, 22 Jul 2025 05:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753161873; cv=none; b=e/RRVsc+RN9pvRAXgG05sfaalBEyupPMvoHq+13NgSV1ngrQ4sy7RIpmTrOPyGwAKsNLlQ/NDAg6EEODtRapR+Zf1pqrIYuZYkTM7bMh7vKTdjB/UIdrmvDkrxcgrH+sSd5vXSAnP/QUzY/hDVLkX4x6nH08XFyy6q2O5N70C6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753161873; c=relaxed/simple; bh=Avp0JiTSYhNMuMn8G13FVQY07A41ztSui4s3Y/jRy7U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=DO4OsKlQ6Nau5kCEjj6cG1ePewbb3jZczPSnrXQknCFgNmWqyqAiqAvTjYJBfAdUhH9flOAoh68uI6MbUHAwOHho0LVCAqAv0njyRTciLOqDPbEaQnTYX7Sn66SZpHRzeLXFo7N8trdcVgo8ylApWI7hAQPu54/NvfEn2RRnY4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nurNrhI9; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nurNrhI9" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-32b31afa781so40038441fa.3 for ; Mon, 21 Jul 2025 22:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1753161870; x=1753766670; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dqDwtUCqJNRnpiOi+aWGhs1F5rEMAyBkONqi7ZgeqbQ=; b=nurNrhI9SV5BXVAk1hHf8Sx6gwl6F3HLcis3HZTm8MRDW82JuIGaxk3Ei3quEJRwgw e/bTb1nlL7lo8ptA2dtU43a6j3+chryW4TcAvFSddv1Zbub2Q3tEL0GlLRc62kPwNsJF Ed2UcdrLMTMSw8FPiKlU0g+BjovBIg2ywMD+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753161870; x=1753766670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dqDwtUCqJNRnpiOi+aWGhs1F5rEMAyBkONqi7ZgeqbQ=; b=W53uFeMH397igXlYii3pPsHS85AzXkLfXNeMsZtHBvXQEZMiHna/WChZ/ps+mckMr2 YrQC1xM1m4CK1ftTX2f3FrGH9ZWPHqNK+UiWXs+1IJVanosZXmpWdjf7FJOSL3DxBxqD hVA/TpQ1egFVNeSJqMGw+bRnuNZoOI7MAggNEA5bYcN7FzEBnIjA0r2KQheg1MwrGYwF 3FMR2YGTQZjEpG9qg/i+wVUZ0z8keqqWsIqrzbf/XJsQbY0eZbI0MXehJ1h1RB7RdIHo UioXzaaEODpYgcz0PT68ILJLbU+VxCaQoumvz9Rnw6GpVt812LyossbULPoW3+gho59J qeWg== X-Forwarded-Encrypted: i=1; AJvYcCWvsqSA/DCxNQh/i+aaSUiCGiYnm9BrRIvUs6aIkl1l+New9854Z1TIHuz/exHrYoxSleKJr3q9u/hgkOo=@vger.kernel.org X-Gm-Message-State: AOJu0YzITocYurFAQ8vo05FMb0tTN+lFFrWMHxq6TliDfHidTt7B7iBQ UBUZIl+hugsMGK1vE/Tei0XJpP5mev/bsAyEkqo38ojqzdZgTMkm6Rxyz0DoXjxb03CQ2wSdhsr xFgjFlskJr3B1b8V3t3IiA/iJn9ZJhTmmYG9v65o4 X-Gm-Gg: ASbGncs/SSnFSDJ0ZGRx/VLrdT7rGxmlkIAs1GjGlgQxDECrbjn9QX+TuPkAZBebgi6 HDxW5aOsR+LpxL9LnG8WbulhSSp5UdwnRd64YQRFS5dXJ0Hj3MI+ggPeqT7hoSnPex6REI1PkJr W/hyJ1t9Iu3IKKMDvzjKtwtb2N2iOG6MimxnjOO4zzryUioaOnWCnRT+Ot8eMfj9x0frTo18rg8 cMvczmXpQUGW/2uI0+kKnAlOH5pqSvOLNzbR3b9792Rjw== X-Google-Smtp-Source: AGHT+IEdOx5zCqoNPg2UT45LQbL+jHOpKPo6tn9yxf52DBYuUr7UN/c4OmqYmGkjvaYN6I6H6AP02HgZdnn60DMD5bo= X-Received: by 2002:a05:651c:419b:b0:32f:425b:3278 with SMTP id 38308e7fff4ca-3308f5df835mr61834191fa.25.1753161870330; Mon, 21 Jul 2025 22:24:30 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250715140224.206329-1-angelogioacchino.delregno@collabora.com> <20250715140224.206329-4-angelogioacchino.delregno@collabora.com> <20250717152947.GA3411864-robh@kernel.org> In-Reply-To: <20250717152947.GA3411864-robh@kernel.org> From: Chen-Yu Tsai Date: Tue, 22 Jul 2025 13:24:19 +0800 X-Gm-Features: Ac12FXzJ2_kEeBPPtFnHpLPdeiuzsl4YpgJm_YvA17xvKg2-LMZYsB2VDzsxF1w Message-ID: Subject: Re: [PATCH v5 3/8] dt-bindings: regulator: Document MediaTek MT6363 PMIC Regulators To: AngeloGioacchino Del Regno Cc: Rob Herring , linux-mediatek@lists.infradead.org, lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 17, 2025 at 11:29=E2=80=AFPM Rob Herring wrot= e: > > On Tue, Jul 15, 2025 at 04:02:19PM +0200, AngeloGioacchino Del Regno wrot= e: > > Add bindings for the regulators found in the MediaTek MT6363 PMIC, > > usually found in board designs using the MT6991 Dimensity 9400 and > > on MT8196 Kompanio SoC for Chromebooks, along with the MT6316 and > > MT6373 PMICs. > > > > Signed-off-by: AngeloGioacchino Del Regno > > --- > > .../regulator/mediatek,mt6363-regulator.yaml | 193 ++++++++++++++++++ > > 1 file changed, 193 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/mediate= k,mt6363-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt636= 3-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6= 363-regulator.yaml > > new file mode 100644 > > index 000000000000..ea1f6c92cffc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6363-regul= ator.yaml > > @@ -0,0 +1,193 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6363-regulator= .yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek MT6363 PMIC Regulators > > + > > +maintainers: > > + - AngeloGioacchino Del Regno > > + > > +description: > > + The MT6363 SPMI PMIC provides 10 BUCK and 25 LDO (Low DropOut) regul= ators > > + and can optionally provide overcurrent warnings with one ocp interru= pt > > + for each voltage regulator. > > + > > +properties: > > + compatible: > > + const: mediatek,mt6363-regulator > > + > > + reg: > > + maxItems: 1 > > + > > + vsys-vbuck1-supply: > > + description: Input supply for vbuck1 > > blank line > > > + vsys-vbuck2-supply: > > + description: Input supply for vbuck2 > > blank line, and so on... > > > + vsys-vbuck3-supply: > > + description: Input supply for vbuck3 > > + vsys-vbuck4-supply: > > + description: Input supply for vbuck4 > > + vsys-vbuck5-supply: > > + description: Input supply for vbuck5 > > + vsys-vbuck6-supply: > > + description: Input supply for vbuck6 > > + vsys-vbuck7-supply: > > + description: Input supply for vbuck7 > > + vsys-vs1-supply: > > + description: Input supply for vs1 > > + vsys-vs2-supply: > > + description: Input supply for vs2 > > + vsys-vs3-supply: > > + description: Input supply for vs3 You could also merge the ones above with a regex and move it to patternProperties. Since these are one to one mappings that should work still. > > + vs1-ldo1-supply: > > + description: Input supply for va15, vio0p75, vm18, vrf18, vrf-io18 > > + vs1-ldo2-supply: > > + description: Input supply for vcn15, vio18, vufs18 > > + vs2-ldo1-supply: > > + description: Input supply for vsram-cpub, vsram-cpum, vrf12, vrf13= , vufs12 > > + vs2-ldo2-supply: > > + description: Input supply for va12-1, va12-2, vcn13, vsram-cpul > > + vs3-ldo1-supply: > > + description: Input supply for vsram-apu, vsram-digrf, vsram-mdfe > > + vs3-ldo2-supply: > > + description: Input supply for vsram-modem, vrf0p9 > > + vsys-ldo1-supply: > > + description: Input supply for vaux18, vemc, vtref18 For these, I wonder if the description is really needed. >From a device tree writing point of view, the author is likely looking at the diagram and tracing each of these pins to a supply. They won't care which LDO it's actually feeding. >From an implementer POV, the author is likely looking at the datasheet for other details not spelled out here, such as voltage steps and register offsets. The datasheet also says which supply pin feeds into which LDOs. ChenYu