From: Mateusz Guzik <mjguzik@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hughd@google.com, linux-ext4@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 0/3] symlink length caching
Date: Tue, 19 Nov 2024 19:07:33 +0100 [thread overview]
Message-ID: <CAGudoHFnwtetYnypHWhS8sODnmcjnRy8VkR-YbV0MP9St3g89g@mail.gmail.com> (raw)
In-Reply-To: <20241119175355.GB3484088@mit.edu>
On Tue, Nov 19, 2024 at 6:53 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Tue, Nov 19, 2024 at 10:45:52AM +0100, Mateusz Guzik wrote:
> >
> > On my v1 Jan remarked 1.5% is not a particularly high win questioning
> > whether doing this makes sense. I noted the value is only this small
> > because of other slowdowns.
>
> Do you have a workload in mind which calls readlink() at sufficiently
> high numbers such that this would be noticeable in
> non-micro-benchmarks? What motiviated you to do this work?
>
I'm just messing about here. Given the triviality of the patch I'm not
sure where the objection is coming from. I can point a finger at
changes made by other people for supposed perf gains which are
virtually guaranteed to be invisible in isolation, just like this one.
Anyhow, I landed here from strlen -- the sucker is operating one byte
at a time which I was looking to sort out, but then I noticed that one
of the more commonly executing consumers does not even need to call
it.
--
Mateusz Guzik <mjguzik gmail.com>
next prev parent reply other threads:[~2024-11-19 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:45 [PATCH v2 0/3] symlink length caching Mateusz Guzik
2024-11-19 9:45 ` [PATCH v2 1/3] vfs: support caching symlink lengths in inodes Mateusz Guzik
2024-11-20 4:15 ` wangjianjian (C)
2024-11-20 5:01 ` Matthew Wilcox
2024-11-20 5:10 ` wangjianjian (C)
2024-11-19 9:45 ` [PATCH v2 2/3] ext4: use inode_set_cached_link() Mateusz Guzik
2024-11-19 9:45 ` [PATCH v2 3/3] tmpfs: " Mateusz Guzik
2024-11-19 17:53 ` [PATCH v2 0/3] symlink length caching Theodore Ts'o
2024-11-19 18:07 ` Mateusz Guzik [this message]
2024-11-20 10:33 ` Christian Brauner
2024-11-20 10:42 ` Mateusz Guzik
2024-11-20 11:12 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGudoHFnwtetYnypHWhS8sODnmcjnRy8VkR-YbV0MP9St3g89g@mail.gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox