From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091Ab2JLGUb (ORCPT ); Fri, 12 Oct 2012 02:20:31 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:43062 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161Ab2JLGUa (ORCPT ); Fri, 12 Oct 2012 02:20:30 -0400 MIME-Version: 1.0 In-Reply-To: <20121001152501.GA7978@kroah.com> References: <1349095840-26450-1-git-send-email-christian.gmeiner@gmail.com> <20121001152501.GA7978@kroah.com> From: Christian Gmeiner Date: Fri, 12 Oct 2012 08:20:07 +0200 Message-ID: Subject: Re: [PATCH] leds-ot200: Fix error caused by shifted mask To: Greg KH Cc: akpm@linux-foundation.org, stable@vger.kernel.org, rpurdie@rpsys.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012/10/1 Greg KH : > On Mon, Oct 01, 2012 at 02:50:40PM +0200, Christian Gmeiner wrote: >> During the development of this driver an in-house register >> documentation was used. The last weeks some integration tests >> were done and this problem was found. It turned out that >> the released register documentation is wrong. >> >> The fix is very simple: shift all mask by one. >> >> Signed-off-by: Christian Gmeiner >> --- >> drivers/leds/leds-ot200.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > Thanks... I will inform stable team again if this patch gets into mainline - hopefully soon. -- Christian Gmeiner, MSc