From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEDF7298C18 for ; Mon, 12 May 2025 19:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747077278; cv=none; b=NrGieZKmt+CnV0rVI/7F0w/txX0f3ziXy5yc1oE7kdzjWbWM0ZKAxkYgEf6uZxVtvV5sc9lscZN04OiPDKaraYF5wNPcNPIhA73gCUQN5SC++58zJ87crSFLKyib5IXiiFxJQp04BoPFdbRC17MP8ODf6WsEPnRylAU3XQOsKso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747077278; c=relaxed/simple; bh=nSw3M6rRmpkbciW/XQfxFWq2eszCHwOBQzhvjLxmTOc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=EP2FD1OgnCB91bELdjuBeaWdrmYNEu9PliqpLl56HAEVPTKV7EvEK3Tns3IDugymJH/0nrhS4WjX+lsDvV8H3CEz4zBtCQWIZ1NVLsW9sq1zL03+7Fm+s24fcgbp+zi6B6SRhG9N0nUhCrszdunfd1aGbpwe7bCu9mv6t31IBmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xc2IwTMZ; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xc2IwTMZ" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5f438523d6fso2299a12.1 for ; Mon, 12 May 2025 12:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747077275; x=1747682075; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6grkvz4IGQ6h1k6YUz5SWGU/3xxG7rgL4ytaAoxrVus=; b=xc2IwTMZdItsXeHUzrjLMZltubWngOxbTl8g2Ayj9NoC+nZw73msQi0xVta1qFBgxQ j9RYAuWIWQqlSczjFIRegIBObGYpF/YqfPrHFiFzKrX5z0WvhGMAUQmMGAPKkymW38YP f9/LvUS0JbhJ6sMHaa1hd+K/1w1FyqnTwxwLgsMutPnn+y5U4KaZNzS44wUxi/UeXnJT lAG9UrTGJj7ahrz+gmKrnw7i0GPogNNwXc0vWdIuMZZrK85ovq47jACvQDymvNzkKCzd bxmY4QpY7WZkxsbmWnbquBlNF68kDZx1bIZgn+H9w0E9rujqqf1izKoMlvCYq9Z5Ltx5 hxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747077275; x=1747682075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6grkvz4IGQ6h1k6YUz5SWGU/3xxG7rgL4ytaAoxrVus=; b=VtQWWMKborYtPXWQWXj+QvBREnP+ZlfVIMpG3aVsFScD75oRZSMA/THsQQFY06QBtu Mi4jNGTA1UqrZaY/0KmVEraZOpn+tCZmxUBoOVFnwdt92HUfoBHLGZdIFQcpvXB1uuja ejwFUtTDwZMloCSHZAigiyuXQJ6eHURoetRug7KBEznfNwwCBDoyI+xOg0PNItRRo1Z/ rIQME7aBedzjGarU58indK+Pzt23VYC90s2zuheqYMZKzOweMckRmDXsyDExTEAcdWFw EiNQUXbIYVeH/bn78X0sPwGZBrXiJnIfmWacD6QXDhjXby0zWuPqkJgnKU0Sh4cdjlcV DVfQ== X-Forwarded-Encrypted: i=1; AJvYcCXo6Rm491qGpH2bdeYeSfpy/uNOgHzM5fD9RQ0FsfWegN03vaqhPKkflHYJ8gBnDej4MR/nULcndUBUcWc=@vger.kernel.org X-Gm-Message-State: AOJu0YwQWzb4P+IkTaaiuUeuXfQ1nFES1Rxets8zGLWwlskgQB2ZzO8+ NUEf1foIrUAPyLHCoKk8mSVNUKy9Tg2xeQVM+usVV5TN1/KsRH1N3HfU5wnHYvDNfYWN3Qok4+D FPchDX7qXFBDIaghuUJyZzLYx8GdR5RuRLZZe6/xG X-Gm-Gg: ASbGncvZu/heLwP3GiedJKuMjxsFG55D95/7AmIYnQQ7NOgTtaNBad6i0j6CJOhaOYV 6TtZyYXSfE4u0m/Z1MkAZq5GPKQMkuNMLc+gPRjCHnLZIIrZnNyajPtFpo9wcXApyTwPDQc6DHf WcYyHe2bgIOWTTyUPmhLVSbo6ykg7orE2ZAKUz45kFJR0Q0I+MV8UNTeG65A8Laqs= X-Google-Smtp-Source: AGHT+IFtZat3CxYkRrxuf4LayeSFUTjMOU/UUK6s3flry2QVc1ThfDr5aYHBrgSXAdeNzDz8w9DKO2TrEjr/VQ451Qs= X-Received: by 2002:a05:6402:b2e:b0:5fd:2041:88f7 with SMTP id 4fb4d7f45d1cf-5ff2a33cf76mr16530a12.2.1747077274857; Mon, 12 May 2025 12:14:34 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> <20250512132939.GF45370@system.software.com> In-Reply-To: <20250512132939.GF45370@system.software.com> From: Mina Almasry Date: Mon, 12 May 2025 12:14:13 -0700 X-Gm-Features: AX0GCFuWCsCZDfmhnWSbDcL7YWTV_J17ret_1dOAsScEvpk7dr4EAmn0tHdJSi4 Message-ID: Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc To: Byungchul Park Cc: Pavel Begunkov , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 12, 2025 at 6:29=E2=80=AFAM Byungchul Park w= rote: > > On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote: > > On 5/9/25 12:51, Byungchul Park wrote: > > > To simplify struct page, the page pool members of struct page should = be > > > moved to other, allowing these members to be removed from struct page= . > > > > > > Reuse struct net_iov for also system memory, that already mirrored th= e > > > page pool members. > > > > > > Signed-off-by: Byungchul Park > > > --- > > > include/linux/skbuff.h | 4 +-- > > > include/net/netmem.h | 20 ++++++------ > > > include/net/page_pool/memory_provider.h | 6 ++-- > > > io_uring/zcrx.c | 42 ++++++++++++----------= --- > > > > You're unnecessarily complicating it for yourself. It'll certainly > > conflict with changes in the io_uring tree, and hence it can't > > be taken normally through the net tree. > > > > Why are you renaming it in the first place? If there are good > > It's because the struct should be used for not only io vetor things but > also system memory. Current network code uses struct page as system > memory descriptor but struct page fields for page pool will be gone. > > So I had to reuse struct net_iov and I thought renaming it made more > sense. It'd be welcome if you have better idea. > As I said in another thread, struct page should not embed struct net_iov as-is. struct net_iov already has fields that are unrelated to page (like net_iov_owner) and more will be added in the future. I think what Matthew seems to agree with AFAIU in the other thread is creating a new struct, struct netmem_desc, and having struct net_iov embed netmem_desc. --=20 Thanks, Mina