From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D40CC2D0E2 for ; Tue, 22 Sep 2020 22:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B321208A9 for ; Tue, 22 Sep 2020 22:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600812167; bh=28DgKVCSQ8AtmVLinnnSGG9EAQq7e3P24m7zdsIDN9Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fRH0C6FTUFQRmCzoGEdY3olXEpfi4L/cuqq4XqV5wHCx1HMS3/vKGfEeBWlKD+tcl eXOg1osfIlPDdl1lgyc5PssON2s5H2d+IbPXFEVQEMXlDDgqvszfkUa568xQvEV9zv uCv+FcqU9NHevQfwqkKRQVbCBSpRJ4cBOTTkELZ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbgIVWCq (ORCPT ); Tue, 22 Sep 2020 18:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbgIVWCp (ORCPT ); Tue, 22 Sep 2020 18:02:45 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65A61C0613D0 for ; Tue, 22 Sep 2020 15:02:45 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id q8so19736490lfb.6 for ; Tue, 22 Sep 2020 15:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9SrwEzb31Xx4E4/5IYT6PCuxclh4qqk9m/MLyhgwMmI=; b=UybGIPgVfmz4sbgSOswJNzshSZHqtQt8jovQLccq7RJRlMoL/uSCYbUecmOP6uyM6G Kmu3b12V9FG6AZkk0sW7DAe6ZOtkVQINlLbyn8cnaXFtL0grj5OxbhKDpRoQCuK01JrY tdOC4vvxoM1MVv3Olonw+UvjWWpeD8CHotVMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9SrwEzb31Xx4E4/5IYT6PCuxclh4qqk9m/MLyhgwMmI=; b=kaQICstPqQf7Brt5RL4nVWOkhQNyAlB/gSpGLtev2UypK51l4vTqKj+tHV+tPCNDTw Hb9dNQ72bz+nkWGgezWzfjH0pJEZ4Ksz7Yv4kSn1f+0Izj+gSpW9mA5LyIkgtiKW5UNY yG6P3dFRo83QbYUwu27uM4+8rl4Lbvh6n3/NOVQfzi+Pho1LFGq7zSRPsw5fS6vvUdsA zwE9zxUWOSYnUrhw07US4Eit/65x9mYncc3i7PH2lumoIUDnmeqVSu8uUqXm/IrhfiI6 qg+VK4lDliTrSczge5W1Ezp1tBHySKFdFNFtaAbwGoctHHgYOe8d9iLF/JKlI8/00Psv plrg== X-Gm-Message-State: AOAM530whXOq0YQhfLesix0RobMvNld8z/ppdqZp+9x7QTnojr0lHL5W xjg/TKIkwyBaeHcfoBnlICRzwJgDn++jpw== X-Google-Smtp-Source: ABdhPJxWyaxqymLpjuFPqFlZZP9t2jTmalQ7Qlbp/CbtpzH/ixg5Fi3xuGj/A8ICW2aPY4P/cfbWfA== X-Received: by 2002:a19:c154:: with SMTP id r81mr2372534lff.424.1600812163029; Tue, 22 Sep 2020 15:02:43 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id b72sm3834357lfd.299.2020.09.22.15.02.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 15:02:41 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id y4so15445478ljk.8 for ; Tue, 22 Sep 2020 15:02:41 -0700 (PDT) X-Received: by 2002:a05:651c:514:: with SMTP id o20mr2358186ljp.312.1600812161247; Tue, 22 Sep 2020 15:02:41 -0700 (PDT) MIME-Version: 1.0 References: <20200921184443.72952cb4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200921184443.72952cb4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Linus Torvalds Date: Tue, 22 Sep 2020 15:02:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT] Networking To: Jakub Kicinski Cc: David Miller , Netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 6:44 PM Jakub Kicinski wrote: > > Here are the latest updates from the networking tree: Pulled. But I'd ask for a couple of things for future pull requests: (a) please put "git pull" somewhere in the email (lots of people just put it in the subject by prepending it with "[GIT PULL]" but all I really look for is "git" and "pull" anywhere in the email. You had the "git" but there was no "pull" anywhere). This can be as simple as just adding a "Please pull" or something. Anything to trigger my search terms. Otherwise the pull request doesn't show up when I start doing pulls - I'll see it eventually, but it might end up delayed. (b) please use an imperative sentence structure for the description instead of present tense. The end result reads _much_ better when you look at the end result after the fact. Just as an example: > Ido fixes failure to add bond interfaces to a bridge, the offload-handling > code was too defensive there and recent refactoring unearthed that. > Users complained. Instead of "Ido fixes failure", please just say "Fix failure". We actually have this in our "Submitting Patches" documentation, for the patch descriptions, but it holds for pull request descriptions too, for all the same reasons. There the example is Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. but the issue is kind of the same. Using present tense in particular is very odd when somebody fixed something a year ago and you go back to the description that says "Ido fixes". No, he fixed things long ago. I basically try to make the commit logs be _roughly_ similar (well, there's basically two kinds of logs: the freeform descriptive ones, and the ones that are a list of changes and use bullet points - and then you have the ones that do both). That also involves primarily just describing the _fixes_ (and possibly the problems). Giving credit to the developers is obviously fine, but if you want to call out the developer, please do it _after_ describing the actual fix. Because the commit log (whether for an individual patch or for a merge message) is primarily about what the change is about. Authorship is separate (and generally shows up as such). End result: I rewrote the above wording into - fix failure to add bond interfaces to a bridge, the offload-handling code was too defensive there and recent refactoring unearthed that. Users complained (Ido) and that's basically would be the form I'd prefer things to be in. Also, I'd love to see signed tags. I don't _require_ them for git.kernel.org pulls, but I do prefer them. Thanks, Linus