From: Linus Torvalds <torvalds@linux-foundation.org>
To: zohar@linux.ibm.com
Cc: ebiggers@kernel.org,
James Morris James Morris <jmorris@namei.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string
Date: Mon, 17 Dec 2018 12:31:31 -0800 [thread overview]
Message-ID: <CAHk-=whO8vApZK-4zBeEhUm4Mp-OMii1V9oVCmoOaGZ2faitcg@mail.gmail.com> (raw)
In-Reply-To: <1545078067.10804.13.camel@linux.ibm.com>
On Mon, Dec 17, 2018 at 12:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> It's being used for parsing and displaying the policy, which do need
> to be in sync.
Yes, but it needs a comment somewhere.
Also, the way you use those enums as array indices also implies that
for your case, Opt_err should definitely not be -1, and it should
instead be at the *end* of the enum list (the same way it's at the end
of the array).
That would also automatically mean that "Opt_measure" would have value
0, and the pl(token) macro shouldn't need any offsetting at all,
because the enums and the array indices just automatically match up
(as long as they are always updated together!)
Linus
next prev parent reply other threads:[~2018-12-17 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 15:48 general protection fault in keyctl_pkey_params_get syzbot
2018-11-03 17:30 ` [PATCH] KEYS: fix parsing invalid pkey info string Eric Biggers
2018-11-28 23:20 ` Eric Biggers
2018-12-06 18:26 ` Eric Biggers
2018-12-17 18:12 ` [PATCH RESEND] " Eric Biggers
2018-12-17 18:43 ` Linus Torvalds
2018-12-17 18:49 ` Linus Torvalds
2018-12-17 19:06 ` Linus Torvalds
2018-12-17 19:39 ` Linus Torvalds
2018-12-17 19:51 ` James Bottomley
2018-12-17 20:02 ` Linus Torvalds
2018-12-17 20:29 ` Mimi Zohar
2018-12-18 0:44 ` James Bottomley
2018-12-31 22:45 ` Eric Biggers
2019-01-01 21:08 ` Linus Torvalds
2018-12-17 20:21 ` Mimi Zohar
2018-12-17 20:31 ` Linus Torvalds [this message]
2018-12-18 12:34 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whO8vApZK-4zBeEhUm4Mp-OMii1V9oVCmoOaGZ2faitcg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=syzkaller-bugs@googlegroups.com \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).