* [PATCH] media: atomisp: fix trailing block comment style
@ 2025-07-15 12:18 Michelle Jin
2025-07-15 13:11 ` Tarang Raval
0 siblings, 1 reply; 3+ messages in thread
From: Michelle Jin @ 2025-07-15 12:18 UTC (permalink / raw)
To: andy, hansg, mchehab, sakari.ailus, gregkh, linux-kernel,
linux-media, linux-staging
Cc: lkcamp/patches, koike, Michelle Jin
Fixes a checkpatch.pl warning regarding block comment formatting.
The trailing '*/' on line 78 was moved to a separate line to conform to
Linux kernel coding style guidelines.
Signed-off-by: Michelle Jin <shjy180909@gmail.com>
---
.../media/atomisp/include/linux/atomisp_platform.h | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
index 6146555fe9cf..95e18c7ddc13 100644
--- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
+++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
@@ -73,9 +73,11 @@ enum atomisp_input_format {
/* CSI2-MIPI specific format: YUV data.
*/
ATOMISP_INPUT_FORMAT_YUV420_8_SHIFT, /* YUV420 8-bit (Chroma Shifted
- Pixel Sampling) */
+ * Pixel Sampling)
+ */
ATOMISP_INPUT_FORMAT_YUV420_10_SHIFT, /* YUV420 8-bit (Chroma Shifted
- Pixel Sampling) */
+ * Pixel Sampling)
+ */
/* CSI2-MIPI specific format: Generic long packet data
*/
@@ -119,10 +121,12 @@ struct atomisp_input_stream_info {
enum atomisp_input_stream_id stream;
u8 enable;
/* Sensor driver fills ch_id with the id
- of the virtual channel. */
+ * of the virtual channel.
+ */
u8 ch_id;
/* Tells how many streams in this virtual channel. If 0 ignore rest
- * and the input format will be from mipi_info */
+ * and the input format will be from mipi_info
+ */
u8 isys_configs;
/*
* if more isys_configs is more than 0, sensor needs to configure the
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: atomisp: fix trailing block comment style
2025-07-15 12:18 [PATCH] media: atomisp: fix trailing block comment style Michelle Jin
@ 2025-07-15 13:11 ` Tarang Raval
2025-07-15 13:23 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Tarang Raval @ 2025-07-15 13:11 UTC (permalink / raw)
To: Michelle Jin, andy@kernel.org, hansg@kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Cc: lkcamp/patches@lists.sr.ht, koike@igalia.com
Hi Michelle,
> Fixes a checkpatch.pl warning regarding block comment formatting.
>
> The trailing '*/' on line 78 was moved to a separate line to conform to
> Linux kernel coding style guidelines.
>
> Signed-off-by: Michelle Jin <shjy180909@gmail.com>
> ---
> .../media/atomisp/include/linux/atomisp_platform.h | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> index 6146555fe9cf..95e18c7ddc13 100644
> --- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> +++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h
> @@ -73,9 +73,11 @@ enum atomisp_input_format {
> /* CSI2-MIPI specific format: YUV data.
> */
It would be better as:
/* CSI2-MIPI specific format: YUV data. */
You could further improve readability by converting some
multi-line comments into single-line comments, where
appropriate.
> ATOMISP_INPUT_FORMAT_YUV420_8_SHIFT, /* YUV420 8-bit (Chroma Shifted
> - Pixel Sampling) */
> + * Pixel Sampling)
> + */
> ATOMISP_INPUT_FORMAT_YUV420_10_SHIFT, /* YUV420 8-bit (Chroma Shifted
> - Pixel Sampling) */
> + * Pixel Sampling)
> + */
>
> /* CSI2-MIPI specific format: Generic long packet data
> */
same here
> @@ -119,10 +121,12 @@ struct atomisp_input_stream_info {
> enum atomisp_input_stream_id stream;
> u8 enable;
> /* Sensor driver fills ch_id with the id
> - of the virtual channel. */
> + * of the virtual channel.
> + */
Preferred line length is 80 columns, so I guess.
you can write it in a single line.
Best Regards,
Tarang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: atomisp: fix trailing block comment style
2025-07-15 13:11 ` Tarang Raval
@ 2025-07-15 13:23 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-07-15 13:23 UTC (permalink / raw)
To: Tarang Raval
Cc: Michelle Jin, andy@kernel.org, hansg@kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
lkcamp/patches@lists.sr.ht, koike@igalia.com
On Tue, Jul 15, 2025 at 4:11 PM Tarang Raval
<tarang.raval@siliconsignals.io> wrote:
...
> > /* Sensor driver fills ch_id with the id
> > - of the virtual channel. */
> > + * of the virtual channel.
> > + */
>
> Preferred line length is 80 columns, so I guess.
Yes.
> you can write it in a single line.
/*
* Also note that the correct
* multi-line comment style is
* in this example (with wider lines, of course).
*/
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-15 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 12:18 [PATCH] media: atomisp: fix trailing block comment style Michelle Jin
2025-07-15 13:11 ` Tarang Raval
2025-07-15 13:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).