Re: [PATCH] platform/x86: ideapad-laptop: hide unused 'touchpad_store'

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Mon, May 22, 2017 at 4:07 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> A readonly sysfs property must not have a 'store' function:
>
> drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function]
>
> We can either comment it out or remove the function entirely,
> without a good reason one or or another I picked the second option.

Hmm... I was expecting something like this but didn't get a single
error from kbuild bot.

>
> Fixes: 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/ideapad-laptop.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index f7a4608cc60b..c4c7ae3179c0 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -435,6 +435,8 @@ static ssize_t touchpad_show(struct device *dev,
>         return sprintf(buf, "%lu\n", result);
>  }
>
> +#if 0
> +/* Switch to RO for now: It might be revisited in the future */

Can we use __maybe_unused instead?

-- 
With Best Regards,
Andy Shevchenko