From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969820AbdD3MwN (ORCPT ); Sun, 30 Apr 2017 08:52:13 -0400 Received: from mail-qt0-f173.google.com ([209.85.216.173]:36349 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966847AbdD3MwE (ORCPT ); Sun, 30 Apr 2017 08:52:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170429070515.GB29622@botnar.kaiser.cx> References: <1488234485-26111-1-git-send-email-martin@kaiser.cx> <1492453377-23796-1-git-send-email-martin@kaiser.cx> <1492453377-23796-2-git-send-email-martin@kaiser.cx> <20170418043110.GA30463@kroah.com> <20170418075131.GA15328@botnar.kaiser.cx> <20170418081542.GA2051@kroah.com> <20170418091102.GA17375@botnar.kaiser.cx> <20170429070515.GB29622@botnar.kaiser.cx> From: Andy Shevchenko Date: Sun, 30 Apr 2017 15:52:03 +0300 Message-ID: Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry To: Martin Kaiser Cc: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 29, 2017 at 10:05 AM, Martin Kaiser wrote: > Thus wrote Andy Shevchenko (andy.shevchenko@gmail.com): >> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser wrote: >> Aren't 0 and 0444 different by meaning? > > my undestanding is that proc_create() calls proc_create_data(), where > > if ((mode & S_IALLUGO) == 0) > mode |= S_IRUGO; > > sets mode to 0444 when it was 0. Ah, okay. Fair enough. -- With Best Regards, Andy Shevchenko