From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530
Date: Mon, 29 Jan 2018 14:56:45 +0200 [thread overview]
Message-ID: <CAHp75VfQH6ssvp14HSLNGPL=eUVQCnrC-ifoKMuKoCkR1s=3YA@mail.gmail.com> (raw)
In-Reply-To: <20180129061011.11214-1-kai.heng.feng@canonical.com>
On Mon, Jan 29, 2018 at 8:10 AM, Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
> of box.
>
> The touchpad relies on its _INI method to update its _HID value from
> XXXX0000 to SYNA2393.
> Also, the _STA relies on value of I2CN to report correct status.
>
> Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
> correctly set up, and _INI can get run. The ACPI table in this machine
> is designed to get parsed this way.
> +#ifdef CONFIG_X86
Why do you need separate #ifdef?
> +static const struct dmi_system_id gbl_term_list_dmi_table[] __initconst = {
I think you can just add new items to the existing table, while renaming it like
dsdt_dmi_table -> acpi_quirks_dmi_table
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-01-29 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 6:10 [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 Kai-Heng Feng
2018-01-29 12:56 ` Andy Shevchenko [this message]
2018-01-30 2:46 ` Kai Heng Feng
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 6:07 Kai-Heng Feng
2018-01-30 18:17 ` Andy Shevchenko
2018-01-30 18:37 ` Schmauss, Erik
2018-01-30 19:03 ` Mario.Limonciello
2018-01-30 20:09 ` Moore, Robert
2018-02-08 9:48 ` Rafael J. Wysocki
2018-01-31 4:27 ` Kai Heng Feng
2018-01-31 4:20 ` Kai Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfQH6ssvp14HSLNGPL=eUVQCnrC-ifoKMuKoCkR1s=3YA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).