From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbeA2M4s (ORCPT ); Mon, 29 Jan 2018 07:56:48 -0500 Received: from mail-qt0-f171.google.com ([209.85.216.171]:44844 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbeA2M4r (ORCPT ); Mon, 29 Jan 2018 07:56:47 -0500 X-Google-Smtp-Source: AH8x225rnXUZ/dECqYjuwT9fvoNUMwFuVffqo4TqIvU+M63Mc1VaCtG4aEMN2QkccvM6yfNLmq2OAC6VM00dL98tZhc= MIME-Version: 1.0 In-Reply-To: <20180129061011.11214-1-kai.heng.feng@canonical.com> References: <20180129061011.11214-1-kai.heng.feng@canonical.com> From: Andy Shevchenko Date: Mon, 29 Jan 2018 14:56:45 +0200 Message-ID: Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 To: Kai-Heng Feng Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 8:10 AM, Kai-Heng Feng wrote: > The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out > of box. > > The touchpad relies on its _INI method to update its _HID value from > XXXX0000 to SYNA2393. > Also, the _STA relies on value of I2CN to report correct status. > > Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be > correctly set up, and _INI can get run. The ACPI table in this machine > is designed to get parsed this way. > +#ifdef CONFIG_X86 Why do you need separate #ifdef? > +static const struct dmi_system_id gbl_term_list_dmi_table[] __initconst = { I think you can just add new items to the existing table, while renaming it like dsdt_dmi_table -> acpi_quirks_dmi_table -- With Best Regards, Andy Shevchenko