[PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

[PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

[Darshan R.]

Updated the formatting of function definitions and if statements to match
kernel coding standards. This helps with readability and consistency across
the codebase.

These are non-functional changes aimed at preparing the driver for eventual
mainline readiness by addressing common checkpatch warnings.

Signed-off-by: Darshan R. <rathod.darshan.0896@gmail.com>
---
 .../output/output_1.0/ia_css_output.host.c    | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c471..4f84c6d3622a 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
 
 void
 ia_css_output_encode(
-    struct sh_css_isp_output_params *to,
-    const struct ia_css_output_config *from,
-    unsigned int size)
+	struct sh_css_isp_output_params *to,
+	const struct ia_css_output_config *from,
+	unsigned int size)
 {
 	(void)size;
 	to->enable_hflip = from->enable_hflip;
@@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
 }
 
 int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
-		          const struct ia_css_output1_configuration *from,
+			  const struct ia_css_output1_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
@@ -95,7 +95,7 @@ int ia_css_output_configure(const struct ia_css_binary     *binary,
 }
 
 int ia_css_output0_configure(const struct ia_css_binary    *binary,
-			    const struct ia_css_frame_info *info)
+			     const struct ia_css_frame_info *info)
 {
 	if (info) {
 		struct ia_css_output0_configuration config =
@@ -124,10 +124,12 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
 
 void
 ia_css_output_dump(
-    const struct sh_css_isp_output_params *output,
-    unsigned int level)
+	const struct sh_css_isp_output_params *output,
+	unsigned int level)
 {
-	if (!output) return;
+	if (!output)
+		return;
+
 	ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "enable", output->enable_hflip);
@@ -138,8 +140,8 @@ ia_css_output_dump(
 
 void
 ia_css_output_debug_dtrace(
-    const struct ia_css_output_config *config,
-    unsigned int level)
+	const struct ia_css_output_config *config,
+	unsigned int level)
 {
 	ia_css_debug_dtrace(level,
 			    "config.enable_hflip=%d",
-- 
2.43.0

Re: [PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

[Andy Shevchenko]

On Mon, Jul 28, 2025 at 9:27 AM Darshan R.
<rathod.darshan.0896@gmail.com> wrote:
>
> Updated the formatting of function definitions and if statements to match
> kernel coding standards. This helps with readability and consistency across
> the codebase.
>
> These are non-functional changes aimed at preparing the driver for eventual
> mainline readiness by addressing common checkpatch warnings.

...

>  void
>  ia_css_output_encode(

And what is about the above?

> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +       struct sh_css_isp_output_params *to,
> +       const struct ia_css_output_config *from,
> +       unsigned int size)

...

>  int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,

Seems too much space between _config and *to.

> -                         const struct ia_css_output1_configuration *from,
> +                         const struct ia_css_output1_configuration *from,
>                           unsigned int size)

...

>  int ia_css_output0_configure(const struct ia_css_binary    *binary,

Ditto.

> -                           const struct ia_css_frame_info *info)
> +                            const struct ia_css_frame_info *info)

...

The rest of the code is also subject to the above comments.

...

Btw, somebody else already submitted the similar changes.


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

[Darshan Rathod]

>Hello,

Please disregard this patch. I would like to formally withdraw this patch

Sorry for the noise.

Thanks,
Darshan R.