linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: joe.walter@codesensesolutions.com
Cc: srinivas.pandruvada@linux.intel.com, rafael@kernel.org,
	 viresh.kumar@linaro.org, lenb@kernel.org,
	linux-pm@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Add DMI quirk for Dell Inspiron systems
Date: Wed, 9 Jul 2025 09:28:09 +0200	[thread overview]
Message-ID: <CAJZ5v0h5cLB3X17dLx7-6X4XDkCW2gqRYa_NG-QeRGLv1k0MvA@mail.gmail.com> (raw)
In-Reply-To: <20250606231530.3032-1-joe.walter@codesensesolutions.com>

On Sat, Jun 7, 2025 at 1:42 AM Joe Walter
<joe.walter@codesensesolutions.com> wrote:
>
> Some Dell Inspiron systems experience frequency scaling issues with
> intel_pstate driver where the CPU gets locked at 900MHz after load.
>
> Add DMI quirk table to detect affected Dell Inspiron models and prevent
> intel_pstate from loading, allowing acpi-cpufreq to handle frequency
> scaling instead.
>
> Affected models:
> - Dell Inspiron 15 7000 Gaming
> - Dell Inspiron 7567
> - Dell Inspiron 7559
>
> Tested-by: Joe Walter <joe.walter@codesensesolutions.com>
> Signed-off-by: Joe Walter <joe.walter@codesensesolutions.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 65 ++++++++++++++++++++++------------
>  1 file changed, 42 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 1b1f62ccec92..3aeb04755afa 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -28,7 +28,6 @@
>  #include <linux/pm_qos.h>
>  #include <linux/bitfield.h>
>  #include <trace/events/power.h>
> -#include <linux/dmi.h>
>  #include <linux/units.h>
>
>  #include <asm/cpu.h>
> @@ -48,6 +47,7 @@
>  #ifdef CONFIG_ACPI
>  #include <acpi/processor.h>
>  #include <acpi/cppc_acpi.h>
> +#include <linux/dmi.h>
>  #endif
>
>  #define FRAC_BITS 8
> @@ -299,25 +299,6 @@ struct pstate_funcs {
>
>  static struct pstate_funcs pstate_funcs __read_mostly;
>
> -/* DMI quirk table for systems that should prefer acpi-cpufreq over intel_pstate */
> -static int intel_pstate_prefer_acpi_cpufreq(const struct dmi_system_id *id)
> -{
> -       pr_info("Preferring acpi-cpufreq for %s due to performance issues with intel_pstate\n",
> -               id->ident);
> -       return 1;
> -}
> -
> -static const struct dmi_system_id intel_pstate_acpi_cpufreq_prefer[] = {
> -       {
> -               .callback = intel_pstate_prefer_acpi_cpufreq,
> -               .ident = "Dell Inspiron 15 7000 Gaming",
> -               .matches = {
> -                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> -                       DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 15 7000 Gaming"),
> -               },
> -       },
> -       { }
> -};

This isn't a patch against mainline intel_pstate because there are no
DMI checks in there.

      parent reply	other threads:[~2025-07-09  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 23:15 [PATCH] cpufreq: intel_pstate: Add DMI quirk for Dell Inspiron systems Joe Walter
2025-06-09  1:10 ` srinivas pandruvada
2025-07-09  7:28 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0h5cLB3X17dLx7-6X4XDkCW2gqRYa_NG-QeRGLv1k0MvA@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=joe.walter@codesensesolutions.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).